Add Authorization endpoints to API which lists accounts. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| included do | ||
| extend ActiveModel::Naming unless (method(:model_name) rescue nil) |
There was a problem hiding this comment.
Avoid using rescue in its modifier form.
|
|
||
| class Api::AuthorizationsController < Api::BaseController | ||
| def resource | ||
| Authorization.new(User.find(prx_auth_token.user_id)) |
There was a problem hiding this comment.
I might DRY this out a bit and put User.find(prx_auth_token.user_id) into a find or get user method.
|
@chrisrhoden I had only minor feedback on this, LGTM. |
| # consider if there is a better way to do this - decorate model instead? | ||
| attr_accessor :is_root_resource | ||
|
|
||
| def is_root_resource |
There was a problem hiding this comment.
Rename is_root_resource to root_resource?.
| # encoding: utf-8 | ||
|
|
||
| class Api::AuthorizationsController < Api::BaseController | ||
| private |
There was a problem hiding this comment.
Keep a blank line before and after private.
|
@kookster let me know if I missed something |
kookster
added a commit
that referenced
this pull request
May 1, 2015
Add Authorization endpoints to API which lists accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #99