Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio file fields #138

Merged
merged 4 commits into from
Apr 29, 2016
Merged

Audio file fields #138

merged 4 commits into from
Apr 29, 2016

Conversation

cavis
Copy link
Member

@cavis cavis commented Apr 27, 2016

Updates for publish.prx.org file uploading:

  • Add the writeable position
  • Add the read-only status
  • Infer account_id through the audio_version.story.account_id, if possible. So when POSTing new files through the /audio_versions/:id/audio_files, they get that implicit account set.

@@ -35,6 +36,17 @@ class << @controller; attr_accessor :prx_auth_token; end
assert_response :success
end

it 'can create an audio file for an audio version' do
af_hash = {
upload: "http://thisisatest.com/guid1/test.mp3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

property :filename
property :label
property :status, writeable: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we'd never want to set this through the CMS, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.807% when pulling 82ab64f on feat/audio-file-fields into fc15477 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.807% when pulling 82ab64f on feat/audio-file-fields into fc15477 on master.

@kookster kookster merged commit 129ea99 into master Apr 29, 2016
@kookster kookster deleted the feat/audio-file-fields branch April 29, 2016 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants