Feature: Persistence #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def tags | ||
| (topics + tones + formats + user_tags).map(&:to_tag).uniq.sort | ||
| end | ||
|
|
||
| def tags=(ts) | ||
| self.user_tags = ts.uniq.sort.collect{|t| UserTag.new(name: t) } |
There was a problem hiding this comment.
Prefer map over collect.
Space missing to the left of {.
Space between { and | missing.
| # check if it should be zoomed, suppress if not | ||
| !embed_zoomed?(name, binding[:zoom], options[:zoom]) | ||
| return !embed_zoomed?(name, binding[:zoom], options[:zoom]) |
…ts for deserializing
| @@ -7,11 +7,11 @@ class Api::StoriesController < Api::BaseController | |||
| filter_resources_by :series_id, :account_id | |||
|
|
|||
| def resource | |||
| @story ||= Story.published.visible.find_by_id(params[:id]) | |||
| @story ||= params[:id] ? Story.published.visible.find_by_id(params[:id]) : Story.new | |||
| def longest_version | ||
| audio_versions.sort_by(&:length).last | ||
| end | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at body end.
| @@ -27,6 +27,10 @@ | |||
|
|
|||
| class ActiveSupport::TestCase | |||
| include FactoryGirl::Syntax::Methods | |||
|
|
|||
| def api_request_opts(opts={}) | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
| Story.published.visible.find_by_id(params[:id]) | ||
| else | ||
| Story.new | ||
| end |
There was a problem hiding this comment.
end at 19, 4 is not aligned with if at 15, 15
|
@chrisrhoden - This should be good to go now, finally. |
|
@kookster looks good, working through merge conflicts now |
|
I can do that
|
Conflicts: app/controllers/api/picks_controller.rb app/controllers/concerns/hal_actions.rb app/representers/api/series_representer.rb app/representers/api/story_representer.rb app/representers/api/user_representer.rb test/controllers/concerns/hal_actions_test.rb
| @@ -44,7 +44,7 @@ def params | |||
| def current_user | |||
| FactoryGirl.create(:user) | |||
| end | |||
|
|
|||
cqr
added a commit
that referenced
this pull request
Jan 8, 2015
Support writing to the database via the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle updating of models and database via API calls.