Fix mext soundinfo math #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kookster
commented
Apr 29, 2022
| @@ -182,7 +182,7 @@ export class WaveFileCreator extends WaveFileParser { | |||
| } | |||
| if ( | |||
| (info.sampleRate == 44100 || info.sampleRate == 22050) && | |||
| info.padding | |||
| !info.padding | |||
There was a problem hiding this comment.
This is the issue that needed to be changed - was checking for if there was padding instead o
farski
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a problem where the mext chunk sound information was calculated wrong for 44.1 or 22.05 Khz files with no padding.
Should be 7, was only 3.
Added a fix and additional test for this case.
Also needed to upgrade the closure compiler to work on new m1 laptops ;)