Remove railtie, speed up tests, clean up test structure. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove railtie which should go in `prx_auth-rails` gem. That gem can include controller methods, automatic middleware insertion, and a dependency on this gem. Clean up test directory structure and guardfile. Go from from 1.7 assertions/s (post railtie-related test removal) to 104.4 assertions/s.
|
LGTM, waiting to see if travis passes. |
1 similar comment
|
@kookster should be ready for you to look at |
|
nice, thanks! |
kookster
added a commit
that referenced
this pull request
Apr 22, 2015
Remove railtie, speed up tests, clean up test structure.
|
@kookster I didn't mean you should look at it while you're on vacation! Thanks |
|
(this was an easy one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove railtie which should go in
prx_auth-railsgem. That gem can includecontroller methods, automatic middleware insertion, and a dependency on this
gem.
Clean up test directory structure and guardfile.
Go from from 1.7 assertions/s (post railtie-related test removal) to
104.4 assertions/s.
note: went into this gem because I needed to remove the railtie, which makes working in development (where we have a different certificate location and issuer) a pain in the neck.