Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -295,26 +295,25 @@
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<version>2.2.4</version>
<version>4.9.10</version>
<executions>
<execution>
<id>get-the-git-infos</id>
<goals>
<goal>revision</goal>
</goals>
<phase>initialize</phase>
</execution>
</executions>
<configuration>
<dotGitDirectory>${project.basedir}/.git</dotGitDirectory>
<prefix>git</prefix>
<verbose>false</verbose>
<generateGitPropertiesFile>true</generateGitPropertiesFile>
<generateGitPropertiesFilename>
${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
<format>json</format>
<gitDescribe>
<skip>true</skip>
</gitDescribe>
<generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
<includeOnlyProperties>
<includeOnlyProperty>git.commit.id</includeOnlyProperty>
<includeOnlyProperty>git.build.time</includeOnlyProperty>
</includeOnlyProperties>
<commitIdGenerationMode>full</commitIdGenerationMode>
<format>properties</format>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -472,6 +471,12 @@
<goal>repackage</goal>
</goals>
</execution>
<execution>
<id>build-info</id>
<goals>
<goal>build-info</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
Expand All @@ -485,4 +490,4 @@
</plugin>
</plugins>
</reporting>
</project>
</project>
33 changes: 33 additions & 0 deletions src/main/java/com/iemr/admin/config/SecurityFilterConfig.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.iemr.admin.config;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.web.servlet.FilterRegistrationBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

import com.iemr.admin.utils.JwtAuthenticationUtil;
import com.iemr.admin.utils.JwtUserIdValidationFilter;

@Configuration
public class SecurityFilterConfig {

@Autowired
private JwtAuthenticationUtil jwtAuthenticationUtil;

@Value("${cors.allowed-origins}")
private String allowedOrigins;

@Bean
public FilterRegistrationBean<JwtUserIdValidationFilter> jwtFilterRegistration() {
FilterRegistrationBean<JwtUserIdValidationFilter> registration = new FilterRegistrationBean<>();
registration.setFilter(new JwtUserIdValidationFilter(jwtAuthenticationUtil, allowedOrigins));
registration.addUrlPatterns("/*");
registration.setOrder(1);

// Set name for easier debugging
registration.setName("JwtUserIdValidationFilter");

return registration;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
* AMRIT – Accessible Medical Records via Integrated Technology
* Integrated EHR (Electronic Health Records) Solution
*
* Copyright (C) "Piramal Swasthya Management and Research Institute"
*
* This file is part of AMRIT.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see https://www.gnu.org/licenses/.
*/
package com.iemr.admin.controller.health;

import java.util.Map;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RestController;

import com.iemr.admin.service.health.HealthService;

import io.swagger.v3.oas.annotations.Operation;

@RestController
public class HealthController {

private static final Logger logger = LoggerFactory.getLogger(HealthController.class);

@Autowired
private HealthService healthService;

@Operation(summary = "Health check endpoint")
@GetMapping("/health")
public ResponseEntity<Map<String, Object>> health() {
logger.info("Health check endpoint called");

Map<String, Object> healthStatus = healthService.checkHealth();

// Return 503 if any service is down, 200 if all are up
String status = (String) healthStatus.get("status");
HttpStatus httpStatus = "UP".equals(status) ? HttpStatus.OK : HttpStatus.SERVICE_UNAVAILABLE;

logger.info("Health check completed with status: {}", status);
return ResponseEntity.status(httpStatus).body(healthStatus);
}
}
Copy link
Contributor

@vishwab1 vishwab1 Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the logic (like reading Git properties and building the JSON) into a separate service method instead of writing everything inside the controller. Also, let’s review all the suggestions given by CodeRabbit once again. One of the points to check is the use of StringBuilder, as it might cause issues in some cases.

Original file line number Diff line number Diff line change
Expand Up @@ -21,58 +21,40 @@
*/
package com.iemr.admin.controller.version;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;

import com.iemr.admin.service.version.VersionService;
import com.iemr.admin.utils.response.OutputResponse;

import io.swagger.v3.oas.annotations.Operation;


@RestController
public class VersionController {

private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());

@Operation(summary = "Version information")
@RequestMapping(value = "/version", method = { RequestMethod.GET })
public String versionInformation() {
OutputResponse output = new OutputResponse();
try {
logger.info("version Controller Start");
output.setResponse(readGitProperties());
} catch (Exception e) {
output.setError(e);
}

logger.info("version Controller End");
return output.toString();
}

private String readGitProperties() throws Exception {
ClassLoader classLoader = getClass().getClassLoader();
InputStream inputStream = classLoader.getResourceAsStream("git.properties");

return readFromInputStream(inputStream);
}

private String readFromInputStream(InputStream inputStream) throws IOException {
StringBuilder resultStringBuilder = new StringBuilder();
try (BufferedReader br = new BufferedReader(new InputStreamReader(inputStream))) {
String line;
while ((line = br.readLine()) != null) {
resultStringBuilder.append(line).append("\n");
}
}
return resultStringBuilder.toString();
}
}
private static final Logger logger = LoggerFactory.getLogger(VersionController.class);

@Autowired
private VersionService versionService;

@Operation(summary = "Version information")
@RequestMapping(value = "/version", method = { RequestMethod.GET }, produces = MediaType.APPLICATION_JSON_VALUE)
public String versionInformation() {
OutputResponse output = new OutputResponse();
try {
logger.info("version Controller Start");
output.setResponse(versionService.getVersionInformation());
} catch (Exception e) {
logger.error("Error in version controller", e);
output.setError(e);
}

logger.info("version Controller End");
return output.toString();
}
}
Loading