Skip to content

Update application.properties #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update application.properties #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,22 +117,22 @@ enableIPValidation=false
iemr.extend.expiry.time.changePassword=true
iemr.session.expiry.time.changePassword=600

identity-api-url-advancesearch = IDENTITY_BASE_URL/id/advanceSearch
identity-api-url-getByBenRegIdList = IDENTITY_BASE_URL/id/getByBenRegIdList
identity-api-url-getByPartialBenRegIdList = IDENTITY_BASE_URL/id/getByPartialBenRegIdList
identity-api-url-getByPhoneNum = IDENTITY_BASE_URL/id/getByPhoneNum?phoneNum=
identity-api-url-getByBenId = IDENTITY_BASE_URL/id/getByBenId?benId=
identity-api-url-getByBenRegId = IDENTITY_BASE_URL/id/getByBenRegId?benRegId=
identity-api-url-benCreate = IDENTITY_BASE_URL/id/create
identity-api-url-benEdit = IDENTITY_BASE_URL/id/edit
identity-api-url-benEditEducationCommunity=IDENTITY_BASE_URL/id/editEducationOrCommunity

identity-api-url-getByFamilyId=IDENTITY_BASE_URL/id/searchByFamilyId?familyId=
identity-api-url-getByGovIdentity=IDENTITY_BASE_URL/id/searhByGovIdentity?identity=
identity-api-url-advancesearch =IDENTITY_API_URL/id/advanceSearch
identity-api-url-getByBenRegIdList =IDENTITY_API_URL/id/getByBenRegIdList
identity-api-url-getByPartialBenRegIdList =IDENTITY_API_URL/id/getByPartialBenRegIdList
identity-api-url-getByPhoneNum =IDENTITY_API_URL/id/getByPhoneNum?phoneNum=
identity-api-url-getByBenId =IDENTITY_API_URL/id/getByBenId?benId=
identity-api-url-getByBenRegId =IDENTITY_API_URL/id/getByBenRegId?benRegId=
identity-api-url-benCreate =IDENTITY_API_URL/id/create
identity-api-url-benEdit =IDENTITY_API_URL/id/edit
identity-api-url-benEditEducationCommunity=IDENTITY_API_URL/id/editEducationOrCommunity

identity-api-url-getByFamilyId=IDENTITY_API_URL/id/searchByFamilyId?familyId=
identity-api-url-getByGovIdentity=IDENTITY_API_URL/id/searhByGovIdentity?identity=

## ABHA id based search URL
identity-api-url-getByHealthID=IDENTITY_BASE_URL/id/getByAbhaAddress?healthID=
identity-api-url-getByHealthIDNo=IDENTITY_BASE_URL/id/getByAbhaIdNo?healthIDNo=
identity-api-url-getByHealthID=IDENTITY_API_URL/id/getByAbhaAddress?healthID=
identity-api-url-getByHealthIDNo=IDENTITY_API_URL/id/getByAbhaIdNo?healthIDNo=
Comment on lines +120 to +135
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Migration from IDENTITY_BASE_URL to IDENTITY_API_URL requires code changes

The verification revealed a critical issue: while the properties file has been updated to use IDENTITY_API_URL, the Java implementation in IdentityBeneficiaryServiceImpl.java still uses IDENTITY_BASE_URL. This mismatch will cause runtime failures.

  • src/main/environment/common_ci.properties defines identity-api-url = @env.IDENTITY_API_URL@
  • src/main/java/com/iemr/common/service/beneficiary/IdentityBeneficiaryServiceImpl.java needs to be updated:
    • Contains constant IDENTITY_BASE_URL
    • Uses IDENTITY_BASE_URL in multiple URL replacements
    • Should be changed to use the new IDENTITY_API_URL configuration
🔗 Analysis chain

Verify IDENTITY_API_URL placeholder configuration

The endpoints have been consistently updated to use IDENTITY_API_URL, but we need to ensure this placeholder is properly defined in the environment-specific properties files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for IDENTITY_API_URL definition in properties files
echo "Searching for IDENTITY_API_URL definition..."
fd -e properties -e yml -e yaml | xargs rg "IDENTITY_API_URL\s*="

Length of output: 166

Script:

#!/bin/bash
# Let's try different search patterns and file locations
echo "1. Searching for any IDENTITY related URL configurations..."
rg -i "identity.*url|identity.*api" --type properties --type yaml

echo -e "\n2. Checking for environment-specific property files..."
fd -e properties -e yml -e yaml | grep -i "application-"

echo -e "\n3. Looking for property placeholders in Java files..."
rg "IDENTITY_API_URL|IDENTITY_BASE_URL" --type java

Length of output: 4804



#### Max retry count
Expand Down
Loading