Skip to content

makeing changes for application properties #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2025
Merged

makeing changes for application properties #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f707b11
Update common_ci.properties
srinuatpiramal Jan 23, 2025
e3bbd38
Update application.properties
srinuatpiramal Jan 23, 2025
4ca6eee
Update common_dev.properties
srinuatpiramal Jan 23, 2025
256219e
Update common_example.properties
srinuatpiramal Jan 23, 2025
6af219e
Update common_test.properties
srinuatpiramal Jan 23, 2025
def0765
Update common_uat.properties
srinuatpiramal Jan 23, 2025
67e963d
Update application.properties
srinuatpiramal Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/environment/common_ci.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,4 @@ updateGrievanceTransactionDetails=@env.GRIEVANCE_API_BASE_URL@/grsbepro/igemr109
grievanceUserName = @env.GRIEVANCE_USERNAME@
grievancePassword = @env.GRIEVANCE_PASSWORD@
grievanceUserAuthenticate = @env.GRIEVANCE_USER_AUTHENTICATE@
grievanceDataSyncDuration = 15
grievanceDataSyncDuration = @env.GRIEVANCE_DATA_SYNC_DURATION@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent environment variable usage detected

The change to use @env.GRIEVANCE_DATA_SYNC_DURATION@ is only implemented in CI environment, while other environments (dev, test, UAT) still use hardcoded value of 15. Consider:

  • Standardizing the configuration approach across all environments by using environment variables consistently
  • Updating other environment files (dev, test, UAT) to use the same externalized configuration pattern
🔗 Analysis chain

LGTM! Verify environment variable configuration.

Good change to externalize the grievance data sync duration. This makes the configuration more flexible and consistent with other environment-specific settings in the file.

Please ensure that the environment variable GRIEVANCE_DATA_SYNC_DURATION is properly configured in all deployment environments. Run this script to check the current configuration:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if GRIEVANCE_DATA_SYNC_DURATION is set in environment files
# Note: Adjust the path pattern if environment files are stored elsewhere

echo "Checking environment variable configuration files..."
fd -t f ".*env.*" -x grep -l "GRIEVANCE_DATA_SYNC_DURATION"

Length of output: 174

Script:

#!/bin/bash
# Search for configuration files and environment variable usage

echo "=== Searching for properties and yaml configuration files ==="
fd -e properties -e yml -e yaml

echo -e "\n=== Searching for environment variable pattern across all files ==="
rg -i "grievance.*duration" -g "!*.class" -g "!*.jar"

echo -e "\n=== Checking for any env-related files with different patterns ==="
fd -t f "env|environment" --ignore-case

Length of output: 1654

2 changes: 1 addition & 1 deletion src/main/environment/common_dev.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,4 +180,4 @@ grievanceUserName = <Enter Grievance username>
grievancePassword = <Enter Grievance password>

grievanceUserAuthenticate = <Enter Grievance UserAuthenticate>
grievanceDataSyncDuration = 15
grievanceDataSyncDuration = <Enter Grievience Data Sync Duration>
2 changes: 1 addition & 1 deletion src/main/environment/common_example.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@ grievanceUserName = <Enter Grievance username>
grievancePassword = <Enter Grievance password>

grievanceUserAuthenticate = <Enter Grievance UserAuthenticate>
grievanceDataSyncDuration = 15
grievanceDataSyncDuration = <Enter Grievience Data Sync Duration>
2 changes: 1 addition & 1 deletion src/main/environment/common_test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,4 @@ grievanceUserName = <Enter Grievance username>
grievancePassword = <Enter Grievance password>

grievanceUserAuthenticate = <Enter Grievance UserAuthenticate>
grievanceDataSyncDuration = 15
grievanceDataSyncDuration = <Enter Grievience Data Sync Duration>
2 changes: 1 addition & 1 deletion src/main/environment/common_uat.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,4 @@ grievanceUserName = <Enter Grievance username>
grievancePassword = <Enter Grievance password>

grievanceUserAuthenticate = <Enter Grievance UserAuthenticate>
grievanceDataSyncDuration = 15
grievanceDataSyncDuration = <Enter Grievience Data Sync Duration>
28 changes: 14 additions & 14 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,22 +117,22 @@ enableIPValidation=false
iemr.extend.expiry.time.changePassword=true
iemr.session.expiry.time.changePassword=600

identity-api-url-advancesearch =IDENTITY_API_URL/id/advanceSearch
identity-api-url-getByBenRegIdList =IDENTITY_API_URL/id/getByBenRegIdList
identity-api-url-getByPartialBenRegIdList =IDENTITY_API_URL/id/getByPartialBenRegIdList
identity-api-url-getByPhoneNum =IDENTITY_API_URL/id/getByPhoneNum?phoneNum=
identity-api-url-getByBenId =IDENTITY_API_URL/id/getByBenId?benId=
identity-api-url-getByBenRegId =IDENTITY_API_URL/id/getByBenRegId?benRegId=
identity-api-url-benCreate =IDENTITY_API_URL/id/create
identity-api-url-benEdit =IDENTITY_API_URL/id/edit
identity-api-url-benEditEducationCommunity=IDENTITY_API_URL/id/editEducationOrCommunity

identity-api-url-getByFamilyId=IDENTITY_API_URL/id/searchByFamilyId?familyId=
identity-api-url-getByGovIdentity=IDENTITY_API_URL/id/searhByGovIdentity?identity=
identity-api-url-advancesearch =IDENTITY_BASE_URL/id/advanceSearch
identity-api-url-getByBenRegIdList =IDENTITY_BASE_URL/id/getByBenRegIdList
identity-api-url-getByPartialBenRegIdList =IDENTITY_BASE_URL/id/getByPartialBenRegIdList
identity-api-url-getByPhoneNum =IDENTITY_BASE_URL/id/getByPhoneNum?phoneNum=
identity-api-url-getByBenId =IDENTITY_BASE_URL/id/getByBenId?benId=
identity-api-url-getByBenRegId =IDENTITY_BASE_URL/id/getByBenRegId?benRegId=
identity-api-url-benCreate =IDENTITY_BASE_URL/id/create
identity-api-url-benEdit =IDENTITY_BASE_URL/id/edit
identity-api-url-benEditEducationCommunity=IDENTITY_BASE_URL/id/editEducationOrCommunity

identity-api-url-getByFamilyId=IDENTITY_BASE_URL/id/searchByFamilyId?familyId=
identity-api-url-getByGovIdentity=IDENTITY_BASE_URL/id/searchByGovIdentity?identity=

## ABHA id based search URL
identity-api-url-getByHealthID=IDENTITY_API_URL/id/getByAbhaAddress?healthID=
identity-api-url-getByHealthIDNo=IDENTITY_API_URL/id/getByAbhaIdNo?healthIDNo=
identity-api-url-getByHealthID=IDENTITY_BASE_URL/id/getByAbhaAddress?healthID=
identity-api-url-getByHealthIDNo=IDENTITY_BASE_URL/id/getByAbhaIdNo?healthIDNo=


#### Max retry count
Expand Down
Loading