changes related to 1148 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMM-1148 | Close call API including reattempt logic based on calltype…
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates variable naming and query field ordering while refining retry logic. The identifier Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Service as GrievanceDataSyncImpl
participant DB
Client->>Service: completeGrievanceCall()
Service->>Service: Rename providerServiceMapId to providerServiceMapID
Service->>Service: Evaluate retry conditions (max attempts, call type, call group type)
alt Retry not needed (e.g., "Wrong Number" excluded or max attempts reached)
Service->>DB: Update completed status (set isRetryNeeded=false)
else Retry allowed
Service->>DB: Increment call counter and update retry status
end
Service-->>Client: Return response message ("failure in closing call" if failure)
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
srishtigrp78
added a commit
to srishtigrp78/Common-API
that referenced
this pull request
Feb 28, 2025
Merge pull request PSMRI#165 from srishtigrp78/feature/version/upgrade
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID: 1148
-- invalid and wrong number condition
-- condition related to isRetryNeeded and isCompleted
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit