cookieutil change #171
cookieutil change #171
Conversation
WalkthroughThis PR updates the cookie handling logic within the Changes
Sequence Diagram(s)sequenceDiagram
participant Server
participant CookieUtil
participant Response
Server->>CookieUtil: addJwtTokenToCookie(response, jwtToken)
CookieUtil->>Response: Prepare cookie
Note over CookieUtil: response.addCookie(cookie) is commented out
CookieUtil-->>Server: Cookie not added
sequenceDiagram
participant Client
participant Request
participant CookieUtil
participant CookieArray
Client->>Request: Sends request
Request->>CookieUtil: getJwtTokenFromCookie(request)
CookieUtil->>Request: call getCookies()
alt Cookies are null
CookieUtil-->>Client: returns null
else Cookies exist
CookieUtil->>CookieArray: iterate to find JWT cookie
CookieArray-->>CookieUtil: returns matching cookie?
CookieUtil-->>Client: returns JWT token
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/iemr/common/utils/CookieUtil.java (1)
44-44: The standard cookie addition has been disabled.The standard method
response.addCookie(cookie)has been commented out, leaving only the manual Set-Cookie header approach active. According to retrieved learnings, both approaches were previously confirmed to work as required. Consider whether disabling the standard method was intentional, as it may affect cookie handling.Given that the manual header is still added at line 60, this change likely removes duplication, but confirm that all environments and browsers still handle the cookie correctly with only the manual approach. The manual approach gives more control over attributes like SameSite.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/iemr/common/utils/CookieUtil.java(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
src/main/java/com/iemr/common/utils/CookieUtil.java (1)
Learnt from: sandipkarmakar3
PR: PSMRI/Common-API#162
File: src/main/java/com/iemr/common/utils/CookieUtil.java:52-66
Timestamp: 2025-02-21T07:43:03.828Z
Learning: In the Common-API project's CookieUtil class, the current implementation of addJwtTokenToCookie using both response.addCookie() and manual Set-Cookie header has been tested and confirmed to work as required for their use case. URL encoding of the JWT token is not necessary.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: style-check / checkstyle
- GitHub Check: Analyze (java)
- GitHub Check: Build
- GitHub Check: Package-test
🔇 Additional comments (1)
src/main/java/com/iemr/common/utils/CookieUtil.java (1)
64-66: Good defensive programming approach.Adding this null check for request cookies prevents potential NullPointerExceptions when iterating through cookies that don't exist. This is a positive change that improves code robustness.
|
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit