-
Notifications
You must be signed in to change notification settings - Fork 45
Fixes for grievance scheduler #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a7a9518
e1b5318
eddabe3
6e626bb
6cf8550
2303d60
68d0483
b7718c0
f9feef6
019d315
507f830
21be52e
0a90728
ea9ff9e
8825473
2d639c4
b0e039b
9831500
5cb6886
9e8e1f2
67b2f86
7b3b990
d834aa9
734551a
47ceb56
f26b8ff
d3534d9
6b58965
8d97517
b5798d2
abe5bd3
3c8fbb9
ef1021e
3451ad5
fa02a49
822ec19
c8e85ab
6557199
9c8afce
4c4cce0
17a159f
c20c9ab
b2d99be
76bf328
eeaf00d
b36477c
48ac080
3fe65c4
b45a6da
55c469a
e6acf34
584f97e
4a4de76
650e573
45b088e
f9ef91b
0e77f26
aaf8db8
713867e
42f00ce
f2478cd
c1cabf6
d78ac62
b042b3c
8b9059a
2f724d3
9b83271
d7a3c6b
fa2f433
ae716f9
84e0139
8055769
060b808
bd061b9
ef33bcd
8fa08c4
36c2ab0
affa900
b2fff57
ce472ee
f5ca14c
b95e4cc
50afdf9
e1465d9
057734c
4933750
079e82a
41c3f09
8806e1b
c88ad77
d33ac0b
474d9ec
d45d5b0
c31f0b4
af51645
67aaeb5
bc3efc5
c029dd6
a709293
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,14 +10,14 @@ public class GrievanceAllocationRequest { | |
|
||
private Timestamp startDate; // Start date for filtering grievances | ||
private Timestamp endDate; // End date for filtering grievances | ||
private List<Integer> userID; // List of user IDs (agents) to whom grievances will be allocated | ||
private List<Integer> touserID; // List of user IDs (agents) to whom grievances will be allocated | ||
private Integer allocateNo; // Number of grievances to be allocated to each user | ||
private String preferredLanguage; | ||
private String language; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π‘ Verification agent π§© Analysis chainField rename from 'preferredLanguage' to 'language'. The variable has been renamed from π Script executed: #!/bin/bash
# Search for any references to 'preferredLanguage' that might not have been updated
rg "preferredLanguage" --type java Length of output: 18647 Action Required: Rename Consistency Issue Across Codebase The field in
Ensure to verify and test all integration points where this field is used. |
||
|
||
@Override | ||
public String toString() { | ||
return "GrievanceAllocationRequest{" + "startDate=" + startDate + ", endDate=" + endDate + ", userID=" + userID | ||
+ ", allocateNo=" + allocateNo + ", language=" + preferredLanguage + '}'; | ||
return "GrievanceAllocationRequest{" + "startDate=" + startDate + ", endDate=" + endDate + ", touserID=" + touserID | ||
+ ", allocateNo=" + allocateNo + ", language=" + language + '}'; | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package com.iemr.common.data.grievance; | ||
|
||
import lombok.Data; | ||
|
||
@Data | ||
public class GrievanceCallRequest { | ||
|
||
String complaintID; | ||
Integer userID; | ||
Boolean isCompleted; | ||
Long beneficiaryRegID; | ||
Integer callTypeID; | ||
Long benCallID; | ||
Integer providerServiceMapID; | ||
String createdBy; | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
package com.iemr.common.data.grievance; | ||
|
||
import java.sql.Timestamp; | ||
|
||
public class GrievanceResponse { | ||
private Long grievanceId; | ||
private String complaintID; | ||
private String primaryNumber; | ||
private String complaintResolution; | ||
private String remarks; | ||
private Timestamp createdDate; | ||
private Timestamp lastModDate; | ||
|
||
// Getters and Setters | ||
public Long getGrievanceId() { | ||
return grievanceId; | ||
} | ||
|
||
public void setGrievanceId(Long grievanceId) { | ||
this.grievanceId = grievanceId; | ||
} | ||
|
||
public String getComplaintID() { | ||
return complaintID; | ||
} | ||
|
||
public void setComplaintID(String complaintID) { | ||
this.complaintID = complaintID; | ||
} | ||
|
||
public String getPrimaryNumber() { | ||
return primaryNumber; | ||
} | ||
|
||
public void setPrimaryNumber(String primaryNumber) { | ||
this.primaryNumber = primaryNumber; | ||
} | ||
|
||
public String getComplaintResolution() { | ||
return complaintResolution; | ||
} | ||
|
||
public void setComplaintResolution(String complaintResolution) { | ||
this.complaintResolution = complaintResolution; | ||
} | ||
|
||
public String getRemarks() { | ||
return remarks; | ||
} | ||
|
||
public void setRemarks(String remarks) { | ||
this.remarks = remarks; | ||
} | ||
|
||
public Timestamp getCreatedDate() { | ||
return createdDate; | ||
} | ||
|
||
public void setCreatedDate(Timestamp createdDate) { | ||
this.createdDate = createdDate; | ||
} | ||
|
||
public Timestamp getLastModDate() { | ||
return lastModDate; | ||
} | ||
|
||
public void setLastModDate(Timestamp lastModDate) { | ||
this.lastModDate = lastModDate; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
Variable name does not follow Java naming conventions.
The variable name
touserID
doesn't follow standard Java naming conventions (camelCase). Consider renaming totoUserId
ortargetUserId
for better readability and consistency.π Committable suggestion