Firebase setup #183
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package com.iemr.common.config.firebase; | ||
|
|
||
| import com.google.auth.oauth2.GoogleCredentials; | ||
| import com.google.firebase.FirebaseApp; | ||
| import com.google.firebase.FirebaseOptions; | ||
| import com.google.firebase.messaging.FirebaseMessaging; | ||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.core.io.ClassPathResource; | ||
|
|
||
| import java.io.ByteArrayInputStream; | ||
| import java.io.IOException; | ||
| import java.util.Base64; | ||
|
|
||
| @Configuration | ||
| public class FirebaseMessagingConfig { | ||
|
|
||
| @Value("${firebase.enabled:false}") | ||
| private boolean firebaseEnabled; | ||
|
|
||
| @Value("${firebase.credential-file:}") | ||
| private String firebaseCredentialFile; | ||
|
|
||
| @Value("${firebase.credential-base64:}") | ||
| private String firebaseCredentialBase64; | ||
|
|
||
| @Bean | ||
| public FirebaseMessaging firebaseMessaging() throws IOException { | ||
| if (!firebaseEnabled) { | ||
| throw new IllegalStateException("Firebase is disabled"); | ||
| } | ||
|
|
||
| GoogleCredentials credentials; | ||
|
|
||
| if (!firebaseCredentialBase64.isBlank()) { | ||
| byte[] decoded = Base64.getDecoder().decode(firebaseCredentialBase64); | ||
| credentials = GoogleCredentials.fromStream(new ByteArrayInputStream(decoded)); | ||
| } else if (!firebaseCredentialFile.isBlank()) { | ||
| credentials = GoogleCredentials.fromStream( | ||
| new ClassPathResource(firebaseCredentialFile).getInputStream() | ||
| ); | ||
| } else { | ||
| throw new IllegalStateException("No Firebase credentials provided"); | ||
| } | ||
|
|
||
| FirebaseOptions options = FirebaseOptions.builder() | ||
| .setCredentials(credentials) | ||
| .build(); | ||
|
|
||
| FirebaseApp firebaseApp = FirebaseApp.getApps().isEmpty() | ||
| ? FirebaseApp.initializeApp(options) | ||
| : FirebaseApp.getInstance(); | ||
|
|
||
| return FirebaseMessaging.getInstance(firebaseApp); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.iemr.common.controller.firebaseNotification; | ||
|
|
||
| import com.iemr.common.model.notification.NotificationMessage; | ||
| import com.iemr.common.service.firebaseNotification.FirebaseNotificationService; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.web.bind.annotation.*; | ||
|
|
||
| @RestController | ||
| @RequestMapping(value= "/firebaseNotification",headers = "Authorization") | ||
| public class FirebaseNotificationController { | ||
| final Logger logger = LoggerFactory.getLogger(this.getClass().getName()); | ||
|
|
||
| @Autowired | ||
| FirebaseNotificationService firebaseNotificationService; | ||
|
|
||
| @RequestMapping(value = "sendNotification",method = RequestMethod.POST) | ||
| public String sendNotificationByToken(@RequestBody NotificationMessage notificationMessage){ | ||
| return firebaseNotificationService.sendNotification(notificationMessage); | ||
| } | ||
|
Comment on lines
+18
to
+21
There was a problem hiding this comment. 🛠️ Refactor suggestion Method name inconsistent with implementation. The method is named Consider these improvements: @RequestMapping(value = "sendNotification",method = RequestMethod.POST)
-public String sendNotificationByToken(@RequestBody NotificationMessage notificationMessage){
- return firebaseNotificationService.sendNotification(notificationMessage);
+public ResponseEntity<String> sendNotificationByToken(@RequestBody @Valid NotificationMessage notificationMessage){
+ try {
+ String result = firebaseNotificationService.sendNotification(notificationMessage);
+ return ResponseEntity.ok(result);
+ } catch (Exception e) {
+ logger.error("Error sending notification: ", e);
+ return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR)
+ .body("Failed to send notification: " + e.getMessage());
+ }
}Don't forget to add the required imports: import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import javax.validation.Valid; |
||
|
|
||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Missing service implementation details.
I cannot find the implementation of
FirebaseNotificationServicethat this controller depends on. The service would need to handle the actual Firebase messaging operations.🌐 Web query:
💡 Result:
To implement Firebase Cloud Messaging (FCM) effectively on the server-side with Java, follow these best practices:
Token Management
Store tokens securely with timestamps using Firestore or your backend database. Track token freshness by updating timestamps regularly (e.g., monthly) to identify stale tokens[4][5].
Refresh tokens periodically using WorkManager to ensure validity[4]:
Prune stale tokens by checking timestamps. Remove tokens older than a defined threshold (e.g., 30 days)[5]:
Message Handling
Use the Firebase Admin SDK for built-in authentication and message validation[1][3]:
Prefer
datamessages for app-controlled behavior. Usenotificationmessages only for UI alerts[7]:Limit message size to under 4,000 bytes and avoid sending redundant keys like
fromormessage_id[8].Error Handling and Retries
Check for failures in multicast sends and log invalid tokens[1]:
Implement exponential backoff for retries. The Admin SDK handles this automatically, but custom implementations should wait at least 10 seconds between attempts[8].
Scaling and Performance
Security
serviceAccountKey.json) using environment variables or secret management tools[3].By following these practices, you ensure efficient, reliable, and scalable FCM integration in Java server environments[1][3][5][8].
Citations:
Action Required: Implement FirebaseNotificationService
The controller currently delegates to
FirebaseNotificationServicewithout any visible implementation details. Based on best practices for Firebase Cloud Messaging with Java, please ensure that the service:serviceAccountKey.json) are protected via environment variables or secret management tools.Addressing these points will strengthen the reliability and security of FCM operations.