Actions update for CodeQL and java #188
Conversation
WalkthroughThe changes update three GitHub Actions workflow files to use newer versions of their respective actions. The Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@drtechie @Sneha6003 can you approve the workflow to check if they pass or not? Is the CodeQL supposed to be behind an approval? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build-on-pull-request.yml(1 hunks).github/workflows/sast.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/sast.yml
[warning] 45-45: wrong indentation: expected 8 but found 10
(indentation)
[error] 47-47: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
.github/workflows/sast.yml (2)
38-41: Upgraded CodeQL init action is correctThe transition from
github/codeql-action/init@v2to@v3, along with explicitlanguages: ${{ matrix.language }}, aligns with CodeQL documentation and ensures the correct languages are scanned.
51-55: Updated CodeQL analyze action is correctThe upgrade to
github/codeql-action/analyze@v3preserves the intendedcategoryinput. No further changes are necessary.
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/sast.yml (1)
30-32: Optional Improvement: Add full clone for CodeQL
For optimal CodeQL analysis (including incremental builds and more accurate blame tracing), it’s recommended to perform a full checkout. You can addfetch-depth: 0to the checkout step as shown:- name: Checkout code - uses: actions/checkout@v3 - with: + uses: actions/checkout@v3 + with: + fetch-depth: 0 ref: ${{ github.event.pull_request.head.ref }} repository: ${{ github.event.pull_request.head.repo.full_name }}🧰 Tools
🪛 actionlint (1.7.4)
31-31: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/package.yml(1 hunks).github/workflows/sast.yml(2 hunks)README.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/package.yml
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/sast.yml
31-31: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (7)
.github/workflows/sast.yml (7)
7-7: Approve: Excludingtarget/**from CodeQL scan
Ignoring thetarget/directory under thepushtrigger reduces noise and speeds up analysis. This pattern is consistent with other workflows in the repo.
12-12: Approve: Excludingtarget/**on pull requests
Matching thepushconfiguration, skipping build artifacts in PR runs prevents unnecessary scanning.
28-28: Skip: Blank line insertion
This is a formatting-only change (empty line) and doesn’t impact the workflow’s behavior.
36-39: Approve: Upgraded CodeQL init action
Switching togithub/codeql-action/init@v3and explicitly passinglanguages: ${{ matrix.language }}aligns with the latest CodeQL setup requirements.
41-46: Approve: Updated Java setup to actions/setup-java@v4
Upgrading toactions/setup-java@v4withjava-version: 17and thetemurindistribution ensures a supported JDK and matches other CI workflows in the repo.
47-49: Skip: Build step formatting
This Maven build step remains functionally identical; only minor whitespace or indentation changed.
50-53: Approve: Upgraded CodeQL analyze action
Updating togithub/codeql-action/analyze@v3withcategory: "/language:${{ matrix.language }}"follows the latest action recommendations and preserves language-specific grouping.
2 participants
📋 Description
JIRA ID: issue link
Updated the depreceated version of codeql and java in github action sast.yml file for correct check passes.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit