Fix identity variable #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces Firebase Cloud Messaging integration, dynamic form management, and beneficiary consent OTP workflows. It adds new REST controllers, DTOs, entities, repositories, and service classes for these features. Configuration files are extended for Firebase and environment-specific settings. JWT utility and beneficiary identity service receive targeted refactoring and error handling improvements. Changes
Sequence Diagram(s)Beneficiary Consent OTP FlowsequenceDiagram
participant Client
participant BeneficiaryConsentController
participant BeneficiaryOTPHandlerImpl
participant SMSGateway
participant Cache
Client->>BeneficiaryConsentController: POST /beneficiaryConsent/sendConsent (mobNo, userName, designation)
BeneficiaryConsentController->>BeneficiaryOTPHandlerImpl: sendOTP(request)
BeneficiaryOTPHandlerImpl->>Cache: Store OTP (encrypted, 5 min expiry)
BeneficiaryOTPHandlerImpl->>SMSGateway: Send OTP SMS
BeneficiaryOTPHandlerImpl-->>BeneficiaryConsentController: Success/Failure message
BeneficiaryConsentController-->>Client: OutputResponse
Client->>BeneficiaryConsentController: POST /beneficiaryConsent/validateConsent (mobNo, otp, ...)
BeneficiaryConsentController->>BeneficiaryOTPHandlerImpl: validateOTP(request)
BeneficiaryOTPHandlerImpl->>Cache: Retrieve OTP
BeneficiaryOTPHandlerImpl-->>BeneficiaryConsentController: Validation result (success/failure)
BeneficiaryConsentController-->>Client: OutputResponse
Firebase Notification Send FlowsequenceDiagram
participant Client
participant FirebaseNotificationController
participant FirebaseNotificationService
participant FirebaseMessaging
Client->>FirebaseNotificationController: POST /firebaseNotification/sendNotification (NotificationMessage)
FirebaseNotificationController->>FirebaseNotificationService: sendNotification(message)
FirebaseNotificationService->>FirebaseMessaging: send(message)
FirebaseMessaging-->>FirebaseNotificationService: Response
FirebaseNotificationService-->>FirebaseNotificationController: Result
FirebaseNotificationController-->>Client: Response
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (35)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
Fix identity variable
✅ Type of Change
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Chores