Skip to content

Nd/vs/fix ben #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 26, 2025
Merged

Nd/vs/fix ben #300

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8bdac2d
fix: add logs
vanitha1822 Sep 26, 2025
3cb2db5
fix: add url
vanitha1822 Sep 26, 2025
49d390d
fix: add logs
vanitha1822 Sep 26, 2025
b883b1e
fix: revert the hardcoded url
vanitha1822 Sep 26, 2025
8ec75fe
fix: resolve the conflicts
vanitha1822 Sep 26, 2025
b8bfa33
removing static field type for env variables
5Amogh Sep 26, 2025
6a92bac
fix: merge with 3.6.0
vanitha1822 Sep 26, 2025
59de7ac
fix: merge with 3.6.0
vanitha1822 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/com/iemr/common/service/beneficiary/IdentityBeneficiaryServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@
private static final String IDENTITY_BASE_URL = "IDENTITY_BASE_URL";

@Value("${genben-api}")
private static String BEN_GEN ;
private String BEN_GEN ;


@Value("${generateBeneficiaryIDs-api-url}")
private static String BEN_GEN_API_URL ;
private String BEN_GEN_API_URL ;


@Override
Expand Down Expand Up @@ -529,8 +529,11 @@
if (auth != null) {
header.put("Authorization", auth);
}

logger.info("Request to generate ben IDs: " + request);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
logger.info("Generating ben IDs API URL: " + BEN_GEN + BEN_GEN_API_URL);
result = httpUtils.post(BEN_GEN + BEN_GEN_API_URL, request, header);

logger.info("Response from generate ben IDs: " + result);
OutputResponse identityResponse = inputMapper.gson().fromJson(result, OutputResponse.class);

if (identityResponse.getStatusCode() == OutputResponse.USERID_FAILURE) {
Expand Down