version changes in action files #77
Conversation
WalkthroughThe GitHub Actions workflows for building, packaging, and static analysis were updated to use newer versions of the setup-java action, moving from version 2 to version 4. Additionally, the Java distribution was switched from 'adopt' to 'temurin' across all workflows. The checkout action in the packaging workflow was also updated from version 2 to version 3. No changes were made to the overall workflow logic or steps beyond these version and configuration updates. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/package.yml (1)
23-23: Remove trailing whitespace
The- name: Checkout codeline has trailing spaces; please remove them to satisfy YAML linting rules.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 23-23: wrong indentation: expected 6 but found 4
(indentation)
[error] 23-23: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml (1)
43-44: Fix YAML indentation underwith:
Thejava-versionanddistributionkeys are over-indented by two spaces. They should be aligned directly underwith:(two spaces deeper thanwith:).- with: - java-version: 17 - distribution: 'temurin' + with: + java-version: 17 + distribution: 'temurin'🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/build-on-pull-request.yml(2 hunks).github/workflows/package.yml(1 hunks).github/workflows/sast.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/package.yml
24-24: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
.github/workflows/package.yml
[error] 25-25: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)
🔇 Additional comments (4)
.github/workflows/build-on-pull-request.yml (1)
16-20: Upgrade and standardize Java setup to v4 with Temurin
TheSetup JDK 17step has been updated to useactions/setup-java@v4and thetemurindistribution, aligning it with other workflows..github/workflows/package.yml (2)
23-24: Upgrade checkout action to v3
Theactions/checkoutstep has been upgraded from@v2to@v3, ensuring compatibility with the latest GitHub Actions runner features.🧰 Tools
🪛 actionlint (1.7.4)
24-24: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[warning] 23-23: wrong indentation: expected 6 but found 4
(indentation)
[error] 23-23: trailing spaces
(trailing-spaces)
27-30: Upgrade and standardize Java setup to v4 with Temurin
TheSetup JDK 17step now usesactions/setup-java@v4with thetemurindistribution, matching other CI workflows for consistency..github/workflows/sast.yml (1)
40-44: Upgrade and standardize Java setup to v4 with Temurin
Updated theSetup JDK 17step toactions/setup-java@v4and switched the distribution totemurin. This aligns with the other workflows and introduces no breaking changes.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/package.yml (1)
23-24: Use latest checkout action and correct indentation
Updated the checkout step toactions/checkout@v3to leverage the latest stable release. Also adjust the indentation understeps:so that list items are two spaces in from thesteps:key (6 spaces total) to satisfy YAML lint.Proposed diff:
steps: - - name: Checkout code - uses: actions/checkout@v3 + - name: Checkout code + uses: actions/checkout@v3🧰 Tools
🪛 actionlint (1.7.4)
24-24: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[warning] 23-23: wrong indentation: expected 6 but found 4
(indentation)
.github/workflows/sast.yml (2)
30-35: Use checkout v3 and fixwithblock indentation
Bumpedactions/checkoutto@v3and added explicitrefandrepositoryinputs. Adjust the indentation of thewith:block so its keys are two spaces in from thewith:key, satisfying YAML lint.Proposed diff:
steps: - - name: Checkout code - uses: actions/checkout@v3 - with: - ref: ${{ github.event.pull_request.head.ref }} - repository: ${{ github.event.pull_request.head.repo.full_name }} + - name: Checkout code + uses: actions/checkout@v3 + with: + ref: ${{ github.event.pull_request.head.ref }} + repository: ${{ github.event.pull_request.head.repo.full_name }}🧰 Tools
🪛 actionlint (1.7.4)
31-31: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[warning] 33-33: wrong indentation: expected 10 but found 12
(indentation)
40-45: Upgrade Java setup action & clean up formatting
Theactions/setup-javastep is now@v4withdistribution: 'temurin', matching the package workflow. Refine the indentation of thewith:inputs and remove trailing spaces on the block for consistency.Proposed diff:
- name: Setup JDK 17 - uses: actions/setup-java@v4 + uses: actions/setup-java@v4 with: - java-version: 17 - distribution: 'temurin' + java-version: 17 + distribution: 'temurin'🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 10 but found 12
(indentation)
[error] 45-45: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/package.yml(1 hunks).github/workflows/sast.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/package.yml
24-24: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/sast.yml
31-31: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
38-38: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
50-50: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
.github/workflows/package.yml
[warning] 23-23: wrong indentation: expected 6 but found 4
(indentation)
[error] 25-25: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml
[warning] 33-33: wrong indentation: expected 10 but found 12
(indentation)
[warning] 43-43: wrong indentation: expected 10 but found 12
(indentation)
[error] 45-45: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/package.yml (1)
27-30: Upgrade Java setup to v4 and switch distribution
Theactions/setup-javastep has been bumped from@v2to@v4and the distribution changed fromadopttotemurin, aligning with other workflows. This matches recommended defaults for modern Java CI.
📋 Description
JIRA ID:
Part of this issue
✅ Type of Change
ℹ️ Additional Information
Summary by CodeRabbit
Summary by CodeRabbit