Skip to content

🩹 [Patch]: Add try/finally blocks #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 22, 2025
Merged

🩹 [Patch]: Add try/finally blocks #38

merged 7 commits into from
Feb 22, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Feb 22, 2025

Description

This pull request includes changes to the action.yml and the addition of a new script file to improve the robustness and cleanliness of the GitHub Action's execution.

Improvements to GitHub Action execution:

  • action.yml: Modified the run block to include a try block for executing scripts and a finally block to ensure the cleanup script is always executed. This change enhances the robustness of the script execution.

Addition of cleanup script:

  • scripts/clean.ps1: Added a new PowerShell script to handle cleanup tasks, including logging debug information and resetting environment variables. This ensures that the environment is properly cleaned up after the action runs.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Feb 22, 2025
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Add begin/process/end/clean blocks 🩹 [Patch]: Add try/finally blocks Feb 22, 2025
@MariusStorhaug MariusStorhaug merged commit bbb4e4e into main Feb 22, 2025
10 checks passed
@MariusStorhaug MariusStorhaug deleted the clean branch February 22, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Set GitHub-Script envvar to $false when done with the action
1 participant