🪲 [Fix]: Get-GitHubContext no longer fails when there are no contexts to return
#402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues related to the GitHub context retrieval by ensuring that Get-GitHubContext handles the case with 0 available contexts without failing, and it updates the PSModule YAML configuration to skip several build, test, and coverage steps.
- Adds a new test case to verify that Get-GitHubContext does not throw and returns an empty value when no contexts exist.
- Updates the .github/PSModule.yml file to skip unnecessary build targets and tests.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/GitHub.Tests.ps1 | Added a test to ensure Get-GitHubContext handles 0 contexts gracefully. |
| .github/PSModule.yml | Updated configuration to skip specific build and test steps. |
…ing instead of throw for missing default context
…lls in anonymous function tests
- Created a template test file for structuring Pester tests. - Implemented tests for GitHub Teams API, including team creation, retrieval, updating, and deletion. - Developed tests for GitHub Users API, covering user retrieval and updates, including email management. - Added extensive tests for GitHub Variables API, focusing on variable creation, updates, retrieval, and deletion across different scopes (user, organization, repository, environment). - Ensured all tests log context and results for better traceability in CI/CD environments. - Included necessary suppressions for Pester warnings to maintain clean test output.
MariusStorhaug
changed the title
Get-GitHubContext should not fail when there are no contexts to return
MariusStorhaug
changed the title
Get-GitHubContext should not fail when there are no contexts to returnGet-GitHubContext no longer fails when there are no contexts to return
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Module GitHub - 0.29.4 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.29.4 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes improvements to
Get-GitHubContext, replacing a thrown exception with a warning, causing it not error out if there are no contexts to return.Error Handling Improvements:
Get-GitHubContextdoes not throw an exception when no contexts are available and returns an empty result.Type of change
Checklist