🪲 [Fix]: Fix issue with parameters and GitHub token access #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd ensuring GH_TOKEN is set
… CI workflow to reflect changes
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies GitHub Actions workflows by removing unused input parameters and improving artifact handling. Key changes include:
- Removing the Debug, Verbose, Version, and Prerelease parameters from workflow and CI files.
- Adding an ArtifactName parameter in Build-Module.yml to specify the artifact name.
- Introducing a GH_TOKEN environment variable in Build-Module.yml for authentication.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/workflow.yml | Removed unused parameters from the Get-Settings step to streamline input parameters. |
| .github/workflows/CI.yml | Removed unused parameters from the Get-Settings step to align with the updated Build-Module. |
| .github/workflows/Build-Module.yml | Removed outdated parameters, added the ArtifactName parameter with a default, and introduced GH_TOKEN. |
MariusStorhaug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates several GitHub Actions workflows to simplify input parameters and improve artifact handling. Key changes include the removal of unused parameters (
Debug,Verbose,Version, andPrerelease) and the addition of anArtifactNameparameter for uploading artifacts. Additionally, environment variables are introduced for authentication.Simplification of input parameters:
.github/workflows/Build-Module.yml: Removed unused parameters (Debug,Verbose,Version, andPrerelease) and added a newArtifactNameparameter to specify the name of the artifact to upload. [1] [2]Environment variable addition:
.github/workflows/Build-Module.yml: Added theGH_TOKENenvironment variable for authentication using GitHub's token.Consistency across workflows:
.github/workflows/CI.ymland.github/workflows/workflow.yml: Removed references to unused parameters (Debug,Verbose,Version, andPrerelease) to align with the updatedBuild-Module.yml. [1] [2]Type of change
Checklist