Skip to content

Conversation

msch-nutrient
Copy link
Collaborator

Summary

  • Separate unit tests from integration tests in CI pipeline
  • Add dedicated integration test job that runs only on pull requests
  • Use Python 3.12 specifically for integration testing
  • Decrypt API key from GitHub secrets and configure integration tests

Changes

  • Modified .github/workflows/ci.yml to:
    • Run unit tests only from tests/unit/ directory in main test job
    • Add new integration-test job that only runs on PRs
    • Create integration_config.py with decrypted NUTRIENT_DWS_API_KEY secret
    • Run integration tests against live Nutrient DWS API on Python 3.12

Test plan

  • Verify unit tests still run on all Python versions (3.8-3.12)
  • Confirm integration tests only run on PRs with Python 3.12
  • Test that integration tests can access live API with decrypted secret
  • Validate that integration tests are skipped when secret is not available

🤖 Generated with Claude Code

msch-nutrient and others added 2 commits June 19, 2025 19:58
- Separate unit tests from integration tests in CI
- Add new integration-test job that runs only on PRs
- Use Python 3.12 specifically for integration tests
- Decrypt NUTRIENT_DWS_API_KEY secret and create integration_config.py
- Run integration tests against live Nutrient DWS API

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use Python to write integration config instead of echo to prevent
API key from being visible in build logs.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@msch-nutrient msch-nutrient force-pushed the add-integration-tests-ci branch from 906921c to 06f62f7 Compare June 19, 2025 17:58
@jdrhyne jdrhyne merged commit 82b4db3 into main Jun 20, 2025
11 checks passed
@jdrhyne
Copy link
Collaborator

jdrhyne commented Jun 20, 2025

Test comment from fine-grained token

msch-nutrient added a commit that referenced this pull request Jun 23, 2025
- Add delete_pdf_pages method to DirectAPIMixin using Build API pattern
- Support flexible page deletion with 0-based indexing
- Automatically handle duplicate page indexes by removing duplicates
- Add comprehensive integration tests with live API verification
- Update documentation in SUPPORTED_OPERATIONS.md with examples
- Follow established patterns from split_pdf and duplicate_pdf_pages implementations
- Note: Negative page indexes not yet supported (limitation documented)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants