Fixing issue #87 #90
Merged
Fixing issue #87 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,12 @@ class PageController extends ContainerAware | |||
| */ | |||
| public function homeAction($repository = 'doctrine/orm') | |||
| { | |||
| return array('repository' => $repository); | |||
|
|
|||
| $redis_reader = $this->container->get('stats_reader'); | |||
There was a problem hiding this comment.
What's the problem exactly here ? I'm not good at CS :-)
There was a problem hiding this comment.
|
great job 👍 |
|
What you mean ? At the moment the counter appears at the top left, I like it this way but if you have advice just tell me. |
|
@hpatoio for me is great, could you fix the CS fix? |
|
Sure, I can run https://github.com/fabpot/PHP-CS-Fixer on all files if you want. |
|
maybe we could close this PR with that simple CS fix, What do you think? |
|
OK. Give me few minutes and I'll fix what @stewe pointed out. |
|
is online :) |
|
Good. BTW. A number format for the counter would have been a good idea. Next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left a couple of comments in the code. Feel free to change what you want. Hope you like it.