Change variable initialization to uniform initialization style and format whitespace in the pga460 driver. #11861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
pga460_driver_work
branch
3 times, most recently
from
f3d04dd
to
6052bb0
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
2 times, most recently
from
600bb80
to
62f04b7
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
2 times, most recently
from
441be8b
to
1bd2d2c
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
from
1bd2d2c
to
41498e4
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
4 times, most recently
from
6f3aac4
to
c2f57ea
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
from
c2f57ea
to
ea1177c
Compare
mcsauder
force-pushed
the
pga460_driver_work
branch
from
ea1177c
to
f3c2ac0
Compare
…rmat whitespace in the pga460 driver and change baud rate unsigned to speed_t type.
mcsauder
force-pushed
the
pga460_driver_work
branch
from
f3c2ac0
to
4bf8d2c
Compare
dagar
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR only migrates the pga460 driver to uniform initialization style and formats whitespace.
Describe your preferred solution
Standardizing all of the distance sensor driver variable initialization, method ordering and general style will allow for future inheritance structure work to be performed on the distance sensor driver classes.
This PR is additional work to promote #9279 in conjunction with #11853, #11857, #11858 and remaining distance sensor driver work.
Describe possible alternatives
All of the distance sensor driver work could be accomplished in one massive PR, but breaking up work in each driver should minimize risk and reduce review effort.
Additional context
See #9279, #11853, #11857, #1858, #11859.
Please let me know if you have any questions on this PR. Thanks!
-Mark
@dakejahl This driver is fantastic! I would love to see all the other serial device driver methods modeled after your methods here. Nice work!