Weekly Digest (16 June, 2019 - 23 June, 2019)

[weekly-digest]

Here's the Weekly Digest for PX4/Firmware:

---

ISSUES

Last week 29 issues were created.
Of these, 15 issues have been closed and 14 issues are still open.

OPEN ISSUES

💚 #12317 Stable v1.9.1 fixes, by dagar
💚 #12315 v1.9.1 TODO, by dagar
💚 #12314 PX4 Models crash Gazebo, by capitalPSA
💚 #12313 Here2 not being detected with PX4 firmware, by donbreum
💚 #12312 Can't get the distance data of the PX4_Flow and sonar, by Martz19
💚 #12310 Request for differential drive robot control, by rishab26201
💚 #12309 Mavlink PLAY_TUNE message does not play tune, by wluker
💚 #12307 RC loss behavior, by RyanHurst
💚 #12306 launch: multiple sdf models, by lamping7
💚 #12305 EKF2_RNG_A_HMAX, EKF2_RNG_A_VMAX missing units in parameter meta data, by DonLakeFlyer
💚 #12304 Removed negative sign from _takeoff_ramp_vz_init, by roangel
💚 #12302 Differential thrust in Tailsitter is link to aileron not rudder, by bluecat1997
💚 #12299 Parameter for virtual battery in SITL, by potaito
💚 #12291 Copter lose altitude and start yaw in mission mode, by MKargus0

CLOSED ISSUES

❤️ #12316 Update submodule jMAVSim to latest Fri Jun 21 20:37:21 EDT 2019, by dagar
❤️ #12311 Fill in thrust field correctly for offboard rates setpoints on fixed wing, by Jaeyoung-Lim
❤️ #12308 px4io can't autostart and can't update, by Evaneee
❤️ #12303 Adding VTOL Octoplane airframe type, by irsdkv
❤️ #12301 [load_mon] pga460 low on stack!, by danielghirst
❤️ #12300 vscode: start gzclient GUI for Gazebo simulation, by julianoes
❤️ #12298 Refactored state-machine strings, by potaito
❤️ #12297 Enable setting simulation speed in VSCode, by julianoes
❤️ #12296 MC rate controller: add I term reduction factor , by bkueng
❤️ #12295 MC mixer: prioritize roll/pitch over yaw for full airmode, by bkueng
❤️ #12294 GPS takes way too long to lock or not locking at all, by HVKHVK
❤️ #12293 Mavlink ODOMETRY (331) support MAV_FRAME_BODY_FLU, by dagar
❤️ #12292 Can't change UAV-Type in Multi-UAV SITL Simulation, by tensarflow
❤️ #12289 Update submodule sitl_gazebo to latest Sun Jun 16 00:37:52 UTC 2019, by dagar
❤️ #12288 Update submodule mavlink v2.0 to latest Sun Jun 16 00:37:57 UTC 2019, by dagar

NOISY ISSUE

🔈 #12294 GPS takes way too long to lock or not locking at all, by HVKHVK
It received 4 comments.

---

PULL REQUESTS

Last week, 58 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 34 pull requests were updated.
💛 #12317 Stable v1.9.1 fixes, by dagar
💛 #12306 launch: multiple sdf models, by lamping7
💛 #12304 Removed negative sign from _takeoff_ramp_vz_init, by roangel
💛 #12299 Parameter for virtual battery in SITL, by potaito
💛 #12279 Pr new vision mav mode, by DanielePettenuzzo
💛 #12259 init.d-posix: support running SITL slower, by julianoes
💛 #12239 Updated gnd_pos_control and removed gnd_att_control, by ItsTimmy
💛 #12229 vtol_att_control move to WQ with uORB callback scheduling, by dagar
💛 #12228 fw_pos_control_l1 move to WQ with uORB callback scheduling, by dagar
💛 #12227 ekf2 move to WQ with uORB callback scheduling, by dagar
💛 #12226 fw_att_control move to WQ with uORB callback scheduling, by dagar
💛 #12225 mc_att_control move to WQ with uORB callback scheduling, by dagar
💛 #12224 px4fmu move to WQ with uORB callback scheduling, by dagar
💛 #12220 Adjustable land speed via RC, by dakejahl
💛 #12209 Implement ModuleParams inheritance and DEFINE_PARAMETERS in the LandDetector class, by mcsauder
💛 #12179 Collision Prevention with distance sensor , by mrivi
💛 #12176 send_event: move to new WQ and uORB::Subscription, by dagar
💛 #12166 Allow more than 4 MC motors in VTOL Simulator, by irsdkv
💛 #12148 Thoneflow 3901U Driver, by mhkabir
💛 #12123 logger move to uORB::SubscriptionInterval, by dagar
💛 #12106 Adding ntest for unit testing on NuttX, by julianoes
💛 #11944 rename fields in tecs_status and make it EAS explicit , by CarlOlsson
💛 #11894 Migrate ulanding driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations, by mcsauder
💛 #11892 Migrate teraranger driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations, by mcsauder
💛 #11891 Migrate srf02 driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations, by mcsauder
💛 #11874 Cherry pick the src/modules/land_detector/ directory and voted_sensors_update.h from PR #9756, by mcsauder
💛 #11861 Change variable initialization to uniform initialization style and format whitespace in the pga460 driver., by mcsauder
💛 #11859 Refactor mb12xx driver class to allow for multiple sensors. Add ability to set sensor addresses. Deprecate rignbuffer and IOCTL., by mcsauder
💛 #11858 Migrate remaining member variable intialization to declarations, employ uniform initialization styling, and standardize method order within leddar_one.cpp, by mcsauder
💛 #11857 Migrate HC_SR04 class member variable initialization to declarations, augment code so that it compiles., by mcsauder
💛 #11853 Migrate cm8jl65 variable initialization from constructor list to declarations, format whitespace/comments, refactor, and deprecate IOCTL., by mcsauder
💛 #11776 Jenkinsfile run unit tests under AddressSanitizer, by dagar
💛 #11676 version: Expose PX4 git tag string, by sfalexrog
💛 #11629 Adis16477 driver standardization work, by mcsauder

MERGED PULL REQUEST

Last week, 24 pull requests were merged.
💜 #12316 Update submodule jMAVSim to latest Fri Jun 21 20:37:21 EDT 2019, by dagar
💜 #12311 Fill in thrust field correctly for offboard rates setpoints on fixed wing, by Jaeyoung-Lim
💜 #12303 Adding VTOL Octoplane airframe type, by irsdkv
💜 #12300 vscode: start gzclient GUI for Gazebo simulation, by julianoes
💜 #12298 Refactored state-machine strings, by potaito
💜 #12297 Enable setting simulation speed in VSCode, by julianoes
💜 #12296 MC rate controller: add I term reduction factor , by bkueng
💜 #12295 MC mixer: prioritize roll/pitch over yaw for full airmode, by bkueng
💜 #12293 Mavlink ODOMETRY (331) support MAV_FRAME_BODY_FLU, by dagar
💜 #12289 Update submodule sitl_gazebo to latest Sun Jun 16 00:37:52 UTC 2019, by dagar
💜 #12288 Update submodule mavlink v2.0 to latest Sun Jun 16 00:37:57 UTC 2019, by dagar
💜 #12284 hardfault_log: fix NULL terminator truncation, by bruenn
💜 #12253 commander refactor and cleanup offboard control mode, by dagar
💜 #12244 Update submodule ecl to latest Tue Jun 11 12:38:12 UTC 2019, by dagar
💜 #12222 drivers/px4io move to uORB::Subscription, by dagar
💜 #12207 uORB Subscription callbacks with WorkItem scheduling on publication, by dagar
💜 #12196 land_detector initiate cycle immediately, by dagar
💜 #12149 Fill the correct throttle field by checking its frametype in offboard mode., by SalimTerryLi
💜 #12147 Sensordots Mappydot+ driver, by mhkabir
💜 #12146 Enable gimbal control using SET_ACTUATOR_CONTROL_TARGET while controlling the vehicle offboard, by Jaeyoung-Lim
💜 #11896 Migrate vl53lxx driver class member variable initialization to declarations, formatting, and deprecate IOCTL usage., by mcsauder
💜 #11893 Migrate tfmini driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations, by mcsauder
💜 #11394 [READY FOR test] Add f7 bl update, by davids5
💜 #11274 Utilize DEFINE_PARAMETERS() macro for params in mavlink_receiver.cpp/h, by mcsauder

---

COMMITS

Last week there were 29 commits.
🛠️ [Update submodule jMAVSim to latest Sat Jun 22 12:37:52 UTC 2019 (#12316) - jMAVSim in PX4/Firmware (fb8630c): https://github.com/PX4/jMAVSim/commit/883413f8b97cc53d48491d6ff3630d6efd2e2467
- jMAVSim current upstream: https://github.com/PX4/jMAVSim/commit/def7501bc0536b8d1050f65d09c7dfbebcc0ce61
- Changes: https://github.com/PX4/jMAVSim/compare/883413f8b97cc53d48491d6ff3630d6efd2e2467...def7501bc0536b8d1050f65d09c7dfbebcc0ce61

 def7501 2019-06-18 romain-chiap - SIH support: add display-only mode for simulation-in-hardware (#101)](https://github.com/PX4/Firmware/commit/d96c97ed48813b0b93a01d4b669ee36dc2633104) by [dagar](https://github.com/dagar)

🛠️ Adding VTOL Octoplane airframe type (#12303) * Srcparser updated, default script for VTOL octoplane added. by irsdkv
🛠️ mc airframes: increase I gains a bit Previous commit allows to increase them again. Partially reverts commit 6c3e79f3614f0060d5998c39be358512101252ff. by bkueng
🛠️ mc rate controller: add I term reduction factor Reduce the I gain for high rate errors to reduce bounce-back effects after flips. Up to 200 degrees the gain is almost not reduced (<25%), so this will only take noticeable effects for large errors (setpoint changes), where we actually want to have an effect. This allows to increase the MC_*RATE_I parameters w/o negative effects when doing flips (i.e. bounce-back after flips). The 400 degrees limit and the x^2 are empirical. The better the rate tracking in general (high P gain), the less this is required (because of the lower tracking error). At the same time it also does not harm, as the i_factor will always be close to 1. by bkueng
🛠️ Mavlink: Fill in thrust field correctly for offboard rates setpoints on fixed wing (#12311) * Fill in thrust field for rates sp by Jaeyoung-Lim
🛠️ Update submodule ecl to latest Tue Jun 18 20:37:33 EDT 2019 - ecl in PX4/Firmware (4673dd0a0c9b90fcab84a26e75812a5c7172d1af): https://github.com/PX4/ecl/commit/0f49eb34a08e499a26d749ed981429047f2100ff - ecl current upstream: https://github.com/PX4/ecl/commit/a036cf82cc92ef6572ea7ee960cfff4d305c01fa - Changes: https://github.com/PX4/ecl/compare/0f49eb34a08e499a26d749ed981429047f2100ff...a036cf82cc92ef6572ea7ee960cfff4d305c01fa a036cf8 2019-06-14 Paul Riseborough - EKF: Remove use of of quaternion self product operator and fix delta rotation sign 0e946f2 2019-06-14 Paul Riseborough - EKF: Remove use of quaternion self product operator and fix delta rotation sign error ad7f7af 2019-05-21 CarlOlsson - ekf: correct quaternion multiplication order d6351bd 2019-05-21 CarlOlsson - EKF: update comment 7612fa4 2019-05-30 Paul Riseborough - EKF: Don't start using GPS for height until all validity checks have passed cef2ba5 2019-05-08 Roman - implemented Kahan summation algorithm for adding process noise to delta angle- and delta velocity bias variance by PX4BuildBot
🛠️ Mavlink receiver SET_ATTITUDE_TARGET fill the correct throttle field by checking its frametype in offboard mode (#12149) by SalimTerryLi
🛠️ vscode: add PX4_SIM_SPEED_FACTOR This env variable can be changed to adapt the simulation speed. by julianoes
🛠️ vscode: use lockstep This changes the VSCode debugging to use lockstep. For lockstep, the rate needs to be 250 Hz. by julianoes
🛠️ jMAVSim: use PX4_SIM_SPEED_FACTOR, not cli arg In order to be consistent between Gazebo and jMAVSim we should be using the env variable PX4_SIM_SPEED_FACTOR in the same way. This enables vscode to set the speed using the env variable. by julianoes
🛠️ vscode: start gzclient GUI for Gazebo simulation by julianoes
🛠️ commander: refactored state-machine strings - Follow-up changes to https://github.com/PX4/Firmware/pull/11796 by potaito
🛠️ uORB Subscription callbacks with WorkItem scheduling on publication (#12207) by dagar
🛠️ mc mixer: prioritize roll/pitch over yaw for full airmode Improves roll/pitch tracking in situations of large yaw demands. by bkueng
🛠️ Modify the update_params() comment to better reflect what is taking place in mavlink_receiver.h. by mcsauder
🛠️ Rename _param_sub to _param_update_sub and initialize. Re-define and re-implement the update_params() method and only call if parameters have been updated. by mcsauder
🛠️ Move variable initialization from constructor to declarations in MavlinkReceiver class, alphabetize var lists. Added update_params() method to ensure that parameters subscribed to are updated routinely. by mcsauder
🛠️ hardfault_log: fix NULL terminator truncation building "make omnibus_f4sd_default" with gcc 8.2.1 failes with: hardfault_log.c:315:7: error: 'strncat' specified bound 30 equals destination size gcc8 introduced -Wstringop-truncation, which will warn about NULL terminator truncation. This patch fixes two similar issues: - strncpy() makes no sense if we want to copy without NULL terminator - strncat() needs space to append the NULL terminator fixes #12283 by bruenn
🛠️ Mavlink ODOMETRY (331) support MAV_FRAME_BODY_FLU by dagar
🛠️ Update submodule mavlink v2.0 to latest Sun Jun 16 00:37:57 UTC 2019 - mavlink v2.0 in PX4/Firmware (067eb41d23252cbc5725f98e63ea56a2951da317): https://github.com/mavlink/c_library_v2/commit/70c1b4ef2db3244df23196bf2e47e369e2e8b78a
- mavlink v2.0 current upstream: https://github.com/mavlink/c_library_v2/commit/18cf6ff2fc0e51e4555b19fc31e8b06eb38bdd79
- Changes: https://github.com/mavlink/c_library_v2/compare/70c1b4ef2db3244df23196bf2e47e369e2e8b78a...18cf6ff2fc0e51e4555b19fc31e8b06eb38bdd79 by dagar
🛠️ [Update submodule sitl_gazebo to latest Sun Jun 16 00:37:52 UTC 2019 - sitl_gazebo in PX4/Firmware (648e7de): https://github.com/PX4/sitl_gazebo/commit/f2593dbcc2980dd15714925931fbb0e46a63a4b2
- sitl_gazebo current upstream: https://github.com/PX4/sitl_gazebo/commit/95adbb11f8deef06fb132bf0eb85c19e6ca00f6e
- Changes: https://github.com/PX4/sitl_gazebo/compare/f2593dbcc2980dd15714925931fbb0e46a63a4b2...95adbb1

 95adbb1 2019-06-08 David Jablonski - fix gstreamer package finding for ubuntu](https://github.com/PX4/Firmware/commit/115b8f83ef1d588ccc80bb75d2a715752e4aafce) by [dagar](https://github.com/dagar)

🛠️ [vl53lxx: migrate variable initialization from constructor list to declaration uniform initialization (#11896) * Format whitespace

• Alphabetize/group/order variables and methods.
• Deprecate IOCTL usage and simplify a few methods.](f1c6674) by mcsauder
  🛠️ [stm32f7 bootloader update support ([READY FOR test] Add f7 bl update #11394) * micro_hal: F7 add flash
• micro_hal: F7 non up_progmem functions
• bl_update: Add F7 Support](f96c47a) by davids5
  🛠️ Mavlink: Enable gimbal control using SET_ACTUATOR_CONTROL_TARGET while controlling the vehicle offboard (#12146) * Stop ignoring setpoints when actuator setpoints are for the gimbal by Jaeyoung-Lim
  🛠️ land_detector initiate cycle immediately - fixes #12190 by dagar
  🛠️ Sensordots Mappydot+ driver (#12147) * Add MappyDot+ driver capable of utilizing multiple sensors on a single i2c bus. by mhkabir
  🛠️ [tfmini: migrate driver class member variable initialization to declarations (Migrate tfmini driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations #11893) * format whitespace
• alphabetize/group/order var/method declarations
• added a default port to start the tfmini driver without requiring arguments.](eaa3d4a) by mcsauder
  🛠️ commander refactor and cleanup offboard control mode by dagar
  🛠️ drivers/px4io move to uORB::Subscription by dagar

---

CONTRIBUTORS

Last week there were 12 contributors.
👤 dagar
👤 irsdkv
👤 bkueng
👤 Jaeyoung-Lim
👤 PX4BuildBot
👤 SalimTerryLi
👤 julianoes
👤 potaito
👤 mcsauder
👤 bruenn
👤 davids5
👤 mhkabir

---

STARGAZERS

Last week there were 24 stagazers.
⭐ srandoux
⭐ XiaoaiSun
⭐ isaackay
⭐ ecust304
⭐ srqqq
⭐ q1426271062
⭐ jannsta1
⭐ hmjack2008
⭐ tomoyukim
⭐ yuchnw
⭐ rynaldi95
⭐ jindegithub
⭐ daumanec
⭐ syzhen
⭐ zhouliangyi
⭐ wangpengcheng
⭐ Nicknyr
⭐ BeingAmirMalik
⭐ Marxlp
⭐ kumekay
⭐ rachavludo
⭐ nowaylv
⭐ mslavescu
⭐ vhelmer
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository PX4/Firmware to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆