Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all PX4 info messages to the PX4Log as well #12954

Merged
merged 3 commits into from Sep 27, 2019

Conversation

Kjkinney
Copy link
Contributor

Describe problem solved by the proposed pull request
We have noticed a lack of information being displayed in the "Logged Messages" console on PX4 Flight Review. It currently only displays WARN level messages.

Test data / coverage
https://review.px4.io/plot_app?log=153160ed-f8a0-4510-954d-4f77b224fa06

Here is a log showing this implemented on a fixed wing vehicle. If you look at the console at the bottom it is now spitting out INFO messages as well.

Describe your preferred solution
I lowered the log level allowed for logging messages in the code.

FYI
@Antiheavy

LorenzMeier
LorenzMeier previously approved these changes Sep 13, 2019
@LorenzMeier
Copy link
Member

Given all these messages are passed through to the user (which means they are considered relevant) it is fair to have all of them in the log. If things are too verbose then we need to fix this by turning text messages intoned QGC UI instead.

@Antiheavy
Copy link
Contributor

This is a huge improvement in my opinion. When analyzing logs from customers or even ourselves, having the extra logged messages easily seen at the bottom of a FlightReview report is very beneficial to getting a quick overview of what happened in the flight.

@dagar
Copy link
Member

dagar commented Sep 13, 2019

I'm in favor of logging all these message, but at the same time I want to encourage capturing the relevant data in something structured that could be sent to the ground. Fields in orb and mavlink messages rather than short english text messages.

@Kjkinney CI is failing due to code style. http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-12954/1/pipeline

image

If you install astyle locally you can run make check_format.

julianoes
julianoes previously approved these changes Sep 25, 2019
@dagar dagar dismissed stale reviews from julianoes and LorenzMeier via fb67f3f September 27, 2019 17:23
@dagar
Copy link
Member

dagar commented Sep 27, 2019

Code style fixed.

@dagar dagar merged commit 3f9b3fb into PX4:master Sep 27, 2019
@dagar
Copy link
Member

dagar commented Sep 27, 2019

Merged to master. Thanks @Kjkinney!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants