ecl-ekf log analysis tool: fix missing filter_fault_status and one-off index bug #9552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
approved these changes
May 29, 2018
|
@JohannesBrand CI fails - please check. |
- analysed_logdata: add filter_fault_status check to test_results dictionary to prevent a missing entry exception - analyse_logdata: fix one-off errors of list indices due to python non-inclusive end indices
JohannesBrand
force-pushed
the
pr-tools-ecl-ekf-one-off-filter-fault-fix
branch
from
c3f7fc4
to
4be8805
Compare
|
@LorenzMeier thank you for reviewing. the CI fail war unrelated and the check passed after re-runnning it (thank you @bkueng). |
priseborough
approved these changes
May 29, 2018
LorenzMeier
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes two bugs of the
analyse_logdata_ekf.pyscript:filter_fault_statusto thetest_resultsdictionary in order to prevent a missing entry exception when thefilter_faultcheck fails (very rare)The index fix should only have minimal influence on the results, but is suggested for correctness.