Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Feature: add NaN set and URT of matrix #80

Merged
merged 7 commits into from
Feb 24, 2019
Merged

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Feb 17, 2019

This PR adds support for:

  • Setting a full matrix or vector with NANs;
  • Get the upper-right triangle of a SquareMatrix.

I also did some improvements on the testing.

@TSC21 TSC21 self-assigned this Feb 17, 2019
@TSC21 TSC21 requested a review from dagar February 17, 2019 17:00
@TSC21
Copy link
Member Author

TSC21 commented Feb 17, 2019

I already tried to run make format and states that all is good. So I don't understand why the format is failing here.

@TSC21 TSC21 changed the title Feature: add std::initializer_list support; add NaN diag matrix and URT Feature: add NaN diag matrix and URT Feb 17, 2019
@TSC21 TSC21 changed the title Feature: add NaN diag matrix and URT Feature: add NaN set and URT of matrix Feb 17, 2019
@coveralls
Copy link

coveralls commented Feb 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 0676719 on feature/init_list_and_nans into 6b0777d on master.

@jgoppert
Copy link
Member

Looks like you need a urt test case.

@TSC21
Copy link
Member Author

TSC21 commented Feb 17, 2019

Looks like you need a urt test case.

Yep I am working on that.

@TSC21 TSC21 force-pushed the feature/init_list_and_nans branch 2 times, most recently from 14630d5 to 2393f15 Compare February 17, 2019 18:22
@TSC21 TSC21 force-pushed the feature/init_list_and_nans branch 2 times, most recently from 64239cc to 088a031 Compare February 17, 2019 18:32
matrix/SquareMatrix.hpp Outdated Show resolved Hide resolved
@TSC21 TSC21 force-pushed the feature/init_list_and_nans branch 4 times, most recently from e51b748 to bf5ba45 Compare February 19, 2019 16:05
@TSC21
Copy link
Member Author

TSC21 commented Feb 19, 2019

@dagar all good now? It's already being used in PX4/PX4-Autopilot#11092.

@TSC21 TSC21 requested a review from bkueng February 21, 2019 14:37
@TSC21
Copy link
Member Author

TSC21 commented Feb 24, 2019

I am merging this as tests pass, it has coverage, and it's already being used on PX4 codebase.

@TSC21 TSC21 merged commit ec436d5 into master Feb 24, 2019
@TSC21 TSC21 deleted the feature/init_list_and_nans branch February 24, 2019 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants