This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I already tried to run |
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 17, 2019 17:40
4ebca91
to
e8cad88
Compare
TSC21
changed the title
Feature: add std::initializer_list support; add NaN diag matrix and URT
Feature: add NaN diag matrix and URT
Feb 17, 2019
TSC21
changed the title
Feature: add NaN diag matrix and URT
Feature: add NaN set and URT of matrix
Feb 17, 2019
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 17, 2019 17:50
e8cad88
to
e560fc4
Compare
Looks like you need a urt test case. |
Yep I am working on that. |
TSC21
force-pushed
the
feature/init_list_and_nans
branch
2 times, most recently
from
February 17, 2019 18:22
14630d5
to
2393f15
Compare
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 17, 2019 18:24
2393f15
to
f7816e0
Compare
TSC21
force-pushed
the
feature/init_list_and_nans
branch
2 times, most recently
from
February 17, 2019 18:32
64239cc
to
088a031
Compare
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 17, 2019 18:40
088a031
to
e553dee
Compare
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 17, 2019 19:04
67ee977
to
0676719
Compare
dagar
reviewed
Feb 18, 2019
TSC21
force-pushed
the
feature/init_list_and_nans
branch
4 times, most recently
from
February 19, 2019 16:05
e51b748
to
bf5ba45
Compare
TSC21
force-pushed
the
feature/init_list_and_nans
branch
from
February 19, 2019 16:12
bf5ba45
to
716e968
Compare
@dagar all good now? It's already being used in PX4/PX4-Autopilot#11092. |
I am merging this as tests pass, it has coverage, and it's already being used on PX4 codebase. |
dagar
reviewed
Mar 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
SquareMatrix
.I also did some improvements on the testing.