-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HRT common code ( and derivatives like Tunes library implementation HRT uses) #8099
Comments
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
This still an issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We need a pass on the htr to do some clean up and document all the interrupt states in the call tree. fyi: @mcsauder see #11351 for the 32 bit timer version. I think this needs a critical section
There is also this that makes no sense
@LorenzMeier, @bkueng, @dagar how would you feel about changing the new hrt_elapsed_time_atomic to be done differently or removed because hrt_absolute_time already has has a critical section. Then The additional overhead is 1 pointer null check and one register load for the call with null ptr and for the call with an offset it is just the math as opposed to 2 cs prologues and epilogues which is many more instructions that add not value. |
@davids5 given that |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Is it still relevant @davids5 ? |
Yes. It is harder to separate it out |
Now that there are 4 chip architectures stm32, stm32F7, Kinetis and samv7
There is a need to isolate the stm32 arch specific code from the arch agnostic code for drivers (hrt in this case) and derivatives. Such as Tunes library implementation .
The text was updated successfully, but these errors were encountered: