ROS leaking in as dependency

[LorenzMeier]

@dagar We need a CI system set up without any ROS to avoid ROS packages leaking in as unintended dependency:

Traceback (most recent call last):
  File "/Users/lorenzmeier/src/Firmware/Tools/sitl_gazebo/scripts/jinja_gen.py", line 9, in <module>
    import rospkg
ImportError: No module named rospkg

@TSC21 FYI

[PX4BuildBot]

GitMate.io thinks possibly related issues are #7335 (GPS coordinate in GPS-denied environments), #4764 (VTOL: Nasty Yaw problem after back trans. in ALT and POS), #6193 (GPS altitude spike feeding into altitude control loop despite GPS fusion disabled), #7675 (Some questions about “mc_att_control” hope to get help), and #7765 (Problem with update firmware pixhawk on aero drone).

[LorenzMeier]

@dagar And Gitmate starts to fail us badly - can we disable related issues? It has no clue what it's doing.

[LorenzMeier]

Just disabled duplicate checking.

[TSC21]

This will be fixed on the container. This is related with the jinja generator. Will fix it today.

…

________________________________ From: Lorenz Meier <notifications@github.com> Sent: Saturday, February 3, 2018 6:12:26 PM To: PX4/Firmware Cc: Nuno Marques; Mention Subject: Re: [PX4/Firmware] ROS leaking in as dependency (#8815) Just disabled duplicate checking. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#8815 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE0JUA8zs-1Ve48fpxaU78LjCeEyUg4eks5tRKGKgaJpZM4R4Q5R>.

[LorenzMeier]

Fixed in df32297

@TSC21 This failed on my machine. So you don't need to fix it on the container. Instead we need a new container without ROS to make sure we're not picking up dependencies we don't want in Firmware.

[TSC21]

The question is that you can install rospkg without ROS. That'a why I added to the install instructions on sitl_gazebo side.

[LorenzMeier]

That's not a good argument. It still becomes a dependency. If you start thinking that way you will have soon hundreds of packages as dependencies and the only working platform will be Ubuntu.

Instead, any package pulled into the system must serve a purpose. If it doesn't (there is no value for non-ROS enabled Gazebo SITL) it must not become a dependency in the first place.

And to enforce all this we need a minimal image running CI.

[TSC21]

I understand. I actually initially was for not adding any ROS dependency but having it available by pip did change my mind. But that makes sense

[dagar]

gitmate silenced (it's still going to be responsible for closing stale issues).

[dagar]

@LorenzMeier rospkg was allowed to slip through because it's available via pip. If you feel strongly about it not being a requirement I think we need to seriously reconsider what's going to be done in sitl_gazebo.