rc_update: cleanup parameter usage

[dagar]

No description provided.

[bkueng]

Nice

[bkueng]

You did not want to keep that check?

[dagar]

I'm not opposed to keeping it, but not in this form printing an error message that's likely never going to be seen by a user. The scaling_factor it clears isn't even used anymore.

[dagar]

@PX4/testflights on any vehicle could you please try fully (re)calibrating RC and verify everything still works? If it checks out on the bench then please test fly and provide a log that can be compared to master. We can use that to compare calibration results before and after.

[Junkim3DR]

Tested on NXP FMUK66 v3

Modes Tested
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure

• Calibrate RC before flying.
  Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint then trigger RTL and see landing behavior.

Notes
No issues noted, good flight in general.

Log

• PR 13672
  • https://review.px4.io/plot_app?log=9dfccd8e-2765-408d-a88a-aac52fd82934
• Master
  • https://review.px4.io/plot_app?log=58aba96b-b0bd-4f8d-98dd-5b8052b6e790

Tested on Pixhawk 4 v5

Modes Tested
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure

• Calibrate RC before flying.
  Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint then trigger RTL and see landing behavior.

Notes
No issues noted, good flight in general.

Log

• PR 13672
  • https://review.px4.io/plot_app?log=a268a939-2dae-4690-96fd-4675f6eeb182
• Master
  • https://review.px4.io/plot_app?log=4e68716c-4c3c-43d4-b4d8-ecc00125d9cb

[jorge789]

Tested on PixRacer V4:

Modes Tested
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure

Calibrate RC before flying.
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint then trigger RTL and see landing behavior.
Notes
No issues noted, good flight in general.

Log

PR 13672
https://review.px4.io/plot_app?log=e6f4466b-2982-4ce9-ba50-0cc38ff76e5f

Master
https://review.px4.io/plot_app?log=56c74d70-5225-47a1-99e4-4ba2aaaacdbf