Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigator: add position setpoint reset helper with safe defaults #13969

Merged
merged 2 commits into from Jan 22, 2020
Merged

navigator: add position setpoint reset helper with safe defaults #13969

merged 2 commits into from Jan 22, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 17, 2020

@RomanBapst how about this for #13965?

@dagar dagar changed the base branch from master to pr-fix_heading_drift_takeoff January 17, 2020 15:59
@dagar dagar force-pushed the pr-fix_heading_drift_takeoff_reset_all branch from 2be90f3 to 9e631b4 Compare January 17, 2020 16:58
@dagar dagar changed the base branch from pr-fix_heading_drift_takeoff to master January 21, 2020 16:15
@dagar dagar force-pushed the pr-fix_heading_drift_takeoff_reset_all branch from 9e631b4 to 7f6bb06 Compare January 21, 2020 16:17
@dagar dagar marked this pull request as ready for review January 21, 2020 16:18
@dagar
Copy link
Member Author

dagar commented Jan 21, 2020

#13965 has merged and I've rebased this on current master.

@dagar dagar requested a review from a team January 22, 2020 14:33
@Tony3dr Tony3dr added this to Ready for testing in Test Flights Jan 22, 2020
@Junkim3DR
Copy link

Junkim3DR commented Jan 22, 2020 •
edited

Tested on NXP FMUK66 v3

Modes Tested
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, for this test specifically: trigger RTL a few times during mission.

Notes
Good flight in general.

Logs

@jorge789
Copy link

jorge789 commented Jan 22, 2020 •
edited

Tested on PixRacer V4

Modes Tested
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Note:
Flight registration started since the battery was connected. Two flights of flight card 2 were made

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, for this test specifically: trigger RTL a few times during mission.

Notes
Good flight in general.

Logs https://review.px4.io/plot_app?log=c024ce73-a155-4373-941c-58f53bfc4a1a

Tested on CUAV nano V5

Modes Tested
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, for this test specifically: trigger RTL a few times during mission.

Notes
Good flight in general.

Log: https://review.px4.io/plot_app?log=9ca60f8f-151c-4f4b-9370-12ebb7cf3989

https://review.px4.io/plot_app?log=7da49ef0-733b-47d4-afc4-6d9dd34ead5e

@dagar dagar merged commit 0e90448 into master Jan 22, 2020
Test Flights automation moved this from Ready for testing to Done Jan 22, 2020
@dagar dagar deleted the pr-fix_heading_drift_takeoff_reset_all branch January 22, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

@RomanBapst RomanBapst Awaiting requested review from RomanBapst

@MaEtUgR MaEtUgR Awaiting requested review from MaEtUgR

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Test Flights
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagar @Junkim3DR @jorge789 @LorenzMeier @RomanBapst