Use jinja templates for multivehicle simulations #15831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches xacro macros to jinja templates for multivehicle simulations.
Jaeyoung-Lim
force-pushed
the
pr-jinja-multivehicle
branch
from
ce40d47
to
1888fd3
Compare
|
The required changes in the submodule has been merged and is included in #15797 |
TSC21
approved these changes
Sep 29, 2020
Jaeyoung-Lim
added a commit
to PX4/PX4-SITL_gazebo-classic
that referenced
this pull request
Oct 5, 2020
xacro macros have been replaced by jinja templates in PX4/PX4-Autopilot#15831, therefore no longer used in the PX4 toolchain. This commit removes rotors_description to deprecate xacro templates completely Remove xacro.py
Jaeyoung-Lim
added a commit
to PX4/PX4-SITL_gazebo-classic
that referenced
this pull request
Oct 7, 2020
xacro macros have been replaced by jinja templates in PX4/PX4-Autopilot#15831, therefore no longer used in the PX4 toolchain. This commit removes rotors_description to deprecate xacro templates completely Remove xacro.py
mvacanti
pushed a commit
to mvacanti/PX4-Autopilot
that referenced
this pull request
Nov 27, 2020
This commit switches xacro macros to jinja templates for multivehicle simulations.
sfuhrer
pushed a commit
that referenced
this pull request
Dec 20, 2020
This commit switches xacro macros to jinja templates for multivehicle simulations.
RyosukeMatsushima
pushed a commit
to RyosukeMatsushima/PX4-SITL_gazebo
that referenced
this pull request
Jun 21, 2022
xacro macros have been replaced by jinja templates in PX4/PX4-Autopilot#15831, therefore no longer used in the PX4 toolchain. This commit removes rotors_description to deprecate xacro templates completely Remove xacro.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Multivehicle simulations in gazebo was run using xacro macros to generate sdf files in the
/tmpdirectory with the necessary port assignments to enable it.However, there are several problem with this infrastructure
standard_vtol)Describe your solution
jina2 templates are now used to generate sdf files at build time. This PR moves the multivehicle script to use jinja templates instead of xacro files. After this is merged, xacro macros will be completely removed from
sitl_gazeboTest data / coverage
Tested in Gazebo SITL:
Additional context