Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commander: preflightcheck only report failure once per sensor type #16206

Merged
merged 1 commit into from
Dec 8, 2020
Merged

commander: preflightcheck only report failure once per sensor type #16206

merged 1 commit into from
Dec 8, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Nov 16, 2020

  • either way the user action is to recalibrate, so we might as well try to minimize the noise/annoyance

@dagar dagar requested a review from MaEtUgR November 16, 2020 16:43
@dagar
commander: preflightcheck only report failure once per sensor type
921b348 
 - either way the user action is to recalibrate, so we might as well try
to minimize the noise/annoyance
MaEtUgR
MaEtUgR approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@MaEtUgR MaEtUgR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I've seen that so many times. I don't see any issues, nice refactoring with the casts.
image

@dagar dagar merged commit 8f5f564 into master Dec 8, 2020
@dagar dagar deleted the pr-preflight_report_once branch December 8, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaEtUgR MaEtUgR MaEtUgR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @MaEtUgR