sensors: prefix mag config param SENS instead of CAL

[bresch]

Solved Problem

CAL_MAG_SIDES and CAL_MAG_ROT_AUTO are not calibration calibrations values of the mag sensor, they are config parameters and shouldn't be saved as part of a factory calibration.

Solution

Change the prefix to SENS_

[junwoo091400]

This PR would get affected by this change. Could we get that PR in first & then rebase these changes on top? @bresch

#20247

[dagar]

Somewhat unfortunately QGC accesses CAL_MAG_SIDES directly.

https://github.com/search?q=repo%3Amavlink%2Fqgroundcontrol%20CAL_MAG_SIDES&type=code

[bresch]

Somewhat unfortunately QGC accesses CAL_MAG_SIDES directly.

if it reads it only, I can leave it but mark it as deprecated and force it to be following the value of SENS_MAG_SIDES directly in the code.

[cmic0]

@bresch something else to consider: this parameter was also stored in the EEPROM, by changing the name we now resolving the problem for future EEPROM parameter save, but previous vehicles that had this CAL_MAG_SIDES parameter saved on the EEPROM will keep loading it.
I think this will result in an annoying CAL_MAG_SIDES not found message, no?

[bresch]

I think this will result in an annoying CAL_MAG_SIDES not found message, no?

I re-added the CAL_MAG_SIDES parameter mainly because QGC needs it to display the correct UI so the parameter is still there and will be overwritten by SENS_MAG_SIDES. However I added a mavlink message to tell the user to use the new parameter in case he wants to change the new one and this message will probably show up when the calibration parameters are loaded.

[dakejahl]

Why not change the logic for param filtering? I understand this is very concise and visually pleasing, but we could easily add a black list of parameters in addition to the CAL_* pattern matching. Then you aren't relying on parameter names, which could easily break in the future if someone unknowingly adds a new CAL_BLAH parameter. Just my 2 cents. Also seems like we might want to rename CAL_MAG_COMP_TYP as well.
https://github.com/PX4/PX4-Autopilot/blob/main/src/modules/commander/factory_calibration_storage.cpp#L50

[bresch]

Why not change the logic for param filtering?

Yes, that was the first idea, but since we anyway wanted to rename it for quite some time, I think it's a good opportunity. That said, I should maybe still add it to the filter now that I had to put it back for QGC

[dagar]

This could be bits now.

[bresch]

The user would then need to select manually which side he wants and I already see ppl not selecting the right ones and having calibration issues...

[dagar]

We could hide it in a different category?

Suggested change

	* @group Sensors
	* @group Sensors
	* @category Developer

[bresch]

Good idea. #20919