Run on separate sitl configs with firmware #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagar @julianoes I am not sure if the SITL failures here are related to the intermittent failures upstream. Could you shed any light if I need to fix this in the submodule layer? |
This was referenced Aug 18, 2020
|
Fix for the comment above was to have Thanks @dagar for the pointers! |
|
Tests are failing |
|
@TSC21 Yes, but not because the PR is incorrect, but this better reflects reality! |
Jaeyoung-Lim
force-pushed
the
pr-run-sitl-test
branch
from
3d86bf2
to
e452836
Compare
jkflying
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running SITL tests on a different config than the firmware.
I also noticed that the
make px4_sitl_default gazeboneeds to be run before changing the submodule branch in order to be on the correct branch. Therefore, this PR includes a workaround of building twice(@bkueng Any idea why this is happening?)
Models running tests
irisstandard_vtolModels with intermittent failures
tailsitterModels that have been tested, but that do not pass the test (therefore not added)
px4vision,solo,typhoon_h480,tiltrotor