Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prod build bug and add sanitizing check for graph data #384

Merged
merged 18 commits into from
Apr 11, 2018
Merged

Fix prod build bug and add sanitizing check for graph data #384

merged 18 commits into from
Apr 11, 2018

Conversation

daming-lu
Copy link
Collaborator

No description provided.

jetfuel
jetfuel previously approved these changes Apr 10, 2018
Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@@ -14,6 +14,8 @@ import {getPluginGraphsGraph} from '../../service';
// for d3 drawing
import * as d3 from 'd3';

import _ from 'lodash';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just do import has from 'lodash'

@daming-lu daming-lu merged commit ac8d570 into PaddlePaddle:develop Apr 11, 2018
@daming-lu daming-lu deleted the fix_prod_extern_link_issue branch April 18, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants