Skip to content

[CodeStyle] run pre-commit on all files #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

[CodeStyle] run pre-commit on all files #7523

merged 2 commits into from
Oct 6, 2025

Conversation

ooooo-create
Copy link
Collaborator

No description provided.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Oct 6, 2025

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-7523.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

SigureMo
SigureMo reviewed Oct 6, 2025
View reviewed changes
docs/dev_guides/custom_device_docs/custom_runtime_cn.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要看一下渲染后的表格是否正常，如果渲染有问题可以 VS Code 装一下 shuworks.vscode-table-formatter 格式化一下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哇塞，牛哇🤩🤩🤩

Copy link
Collaborator Author

@ooooo-create ooooo-create Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

（忘记放预览链接了

http://preview-pr-7523.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/custom_device_docs/custom_runtime_cn.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我又想到一个，是不是可以使用 GitHub action 根据修改的文档文件，自动给出对应预览链接评论，虽然我还不确定触发条件是什么比较好，修改文件数量什么的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的，根据修改的是否是 api 文档来触发

Paddle 那边也亟需这种功能，不然每次都得去 log 里搜关键字 PROMPT 才能找到 url

Copy link
Collaborator Author

@ooooo-create ooooo-create Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刚刚这个表格渲染文件不属于 api 的 docs/dev_guides/custom_device_docs/custom_runtime_cn.rst ，是不主动评论，得 api 触发的时候一起评论，还是选择不评论呀，本来想安装 rst 或者 md 文件，但是万一数量太多了评论好像就没意义了（我好像看见了折叠语法）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

喔喔，那这边的话不止 API 的，是我搞错了

@ooooo-create ooooo-create requested a review from SigureMo October 6, 2025 11:14
@SigureMo SigureMo changed the title [CodeStyle] pre-commit run --all-files [CodeStyle] run pre-commit on all files Oct 6, 2025
SigureMo
SigureMo approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit c3cf3eb into PaddlePaddle:develop Oct 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ooooo-create @SigureMo