Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -Timeout #86

Closed
JustinGrote opened this issue Aug 20, 2024 · 2 comments
Closed

Implement -Timeout #86

JustinGrote opened this issue Aug 20, 2024 · 2 comments

Comments

@JustinGrote
Copy link

JustinGrote commented Aug 20, 2024

A Timeout option would be helpful, for instance not hanging on managed identity if it is not available or responding and move on to the other options. This is natively supported in Azure.Identity and just needs to be passed through to ClientOptions

@PalmEmanuel
Copy link
Owner

Makes sense for sure, thanks for the suggestion!

@PalmEmanuel
Copy link
Owner

PalmEmanuel commented Aug 21, 2024

TimeoutSeconds is already implemented for the other interactive flows, but not -ManagedIdentity.

After doing some experimentation it seems that the ManagedIdentityCredential fully ignores all configuration and ClientOptions that has to do with delays or timeouts, so I'll likely have to implement it myself (which is also doable).

Some reading (which states that it should be improved but that's not my experience with it atm):
Azure/azure-sdk-for-net#29471

Might also reconsider and use the default credential.

Edit: Nvm somehow it started working. I'll implement it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants