Catch the appropriate exception from scssphp #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how the check can fail without you changing something there.. 🤔 |
Macavity
approved these changes
Dec 28, 2021
|
@stof I think you need to merge the latest changes of Paneon:master into your branch, then the checks should succeed. |
The CompilerException class is an internal one, and not all exceptions reporting a Sass error are using it. The contract of the compiler is that exceptions thrown to report Sass errors are implementing the SassException interface.
|
@Macavity done |
tronsha
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CompilerException class is an internal one, and not all exceptions reporting a Sass error are using it.
The contract of the compiler is that exceptions thrown to report Sass errors are implementing the SassException interface.