update enchantment target and rework some component impl

Author: Lulu13022002

paper-api/src/main/java/co/aikar/timings/TimingHistory.java

@@ -51,8 +51,7 @@
 import static co.aikar.util.JSONUtil.*;
 
 /**
- * Internal.
- *
+ * @hidden
  * @deprecated Timings will be removed in the future
  */
 @Deprecated(forRemoval = true)

paper-api/src/main/java/com/destroystokyo/paper/event/brigadier/AsyncPlayerSendCommandsEvent.java

@@ -34,6 +34,7 @@
 public class AsyncPlayerSendCommandsEvent<S extends CommandSourceStack> extends PlayerEvent {
 
     private static final HandlerList HANDLER_LIST = new HandlerList();
+
     private final RootCommandNode<S> node;
     private final boolean hasFiredAsync;
 

paper-api/src/main/java/com/destroystokyo/paper/event/brigadier/AsyncPlayerSendSuggestionsEvent.java

@@ -18,11 +18,12 @@
 public class AsyncPlayerSendSuggestionsEvent extends PlayerEvent implements Cancellable {
 
     private static final HandlerList HANDLER_LIST = new HandlerList();
-    private boolean cancelled = false;
 
     private Suggestions suggestions;
     private final String buffer;
 
+    private boolean cancelled;
+
     @ApiStatus.Internal
     public AsyncPlayerSendSuggestionsEvent(final Player player, final Suggestions suggestions, final String buffer) {
         super(player, !Bukkit.isPrimaryThread());
@@ -57,16 +58,14 @@ public void setSuggestions(final Suggestions suggestions) {
         this.suggestions = suggestions;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean isCancelled() {
         return this.cancelled;
     }
 
     /**
      * Cancels sending suggestions to the client.
+     * <p>
      * {@inheritDoc}
      */
     @Override

paper-api/src/main/java/com/destroystokyo/paper/event/brigadier/CommandRegisteredEvent.java

@@ -24,15 +24,17 @@
 @Warning(reason = "This event has been superseded by the Commands API and will be removed in a future release. Listen to LifecycleEvents.COMMANDS instead.", value = true)
 public class CommandRegisteredEvent<S extends com.destroystokyo.paper.brigadier.BukkitBrigadierCommandSource> extends ServerEvent implements Cancellable {
 
-    private static final HandlerList handlers = new HandlerList();
+    private static final HandlerList HANDLER_LIST = new HandlerList();
+
     private final String commandLabel;
     private final Command command;
     private final com.destroystokyo.paper.brigadier.BukkitBrigadierCommand<S> brigadierCommand;
     private final RootCommandNode<S> root;
     private final ArgumentCommandNode<S, String> defaultArgs;
     private LiteralCommandNode<S> literal;
     private boolean rawCommand = false;
-    private boolean cancelled = false;
+
+    private boolean cancelled;
 
     public CommandRegisteredEvent(String commandLabel, com.destroystokyo.paper.brigadier.BukkitBrigadierCommand<S> brigadierCommand, Command command, RootCommandNode<S> root, LiteralCommandNode<S> literal, ArgumentCommandNode<S, String> defaultArgs) {
         this.commandLabel = commandLabel;
@@ -137,9 +139,6 @@ public void setRawCommand(final boolean rawCommand) {
         this.rawCommand = rawCommand;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean isCancelled() {
         return this.cancelled;
@@ -148,7 +147,7 @@ public boolean isCancelled() {
     /**
      * Cancels registering this command to Brigadier, but will remain in Bukkit Command Map. Can be used to hide a
      * command from all players.
-     *
+     * <p>
      * {@inheritDoc}
      */
     @Override
@@ -158,11 +157,11 @@ public void setCancelled(boolean cancel) {
 
     @NotNull
     public HandlerList getHandlers() {
-        return handlers;
+        return HANDLER_LIST;
     }
 
     @NotNull
     public static HandlerList getHandlerList() {
-        return handlers;
+        return HANDLER_LIST;
     }
 }

paper-api/src/main/java/com/destroystokyo/paper/event/player/PlayerHandshakeEvent.java

@@ -221,25 +221,21 @@ public void setFailMessage(final String failMessage) {
     }
 
     /**
-     * Determines if this event is cancelled.
+     * {@inheritDoc}
      * <p>
      * When this event is cancelled, custom handshake logic will not
      * be processed.
-     *
-     * @return {@code true} if this event is cancelled, {@code false} otherwise
      */
     @Override
     public boolean isCancelled() {
         return this.cancelled;
     }
 
     /**
-     * Sets if this event is cancelled.
+     * {@inheritDoc}
      * <p>
      * When this event is cancelled, custom handshake logic will not
      * be processed.
-     *
-     * @param cancel {@code true} if this event is cancelled, {@code false} otherwise
      */
     @Override
     public void setCancelled(final boolean cancel) {

paper-api/src/main/java/com/destroystokyo/paper/event/player/PlayerJumpEvent.java

@@ -40,8 +40,6 @@ public PlayerJumpEvent(final Player player, final Location from, final Location
      * If this event is cancelled, the player will be moved or
      * teleported back to the Location as defined by {@link #getFrom()}. This will not
      * fire an event
-     *
-     * @return {@code true} if this event is cancelled
      */
     @Override
     public boolean isCancelled() {
@@ -54,8 +52,6 @@ public boolean isCancelled() {
      * If this event is cancelled, the player will be moved or
      * teleported back to the Location as defined by {@link #getFrom()}. This will not
      * fire an event
-     *
-     * @param cancel {@code true} if you wish to cancel this event
      */
     @Override
     public void setCancelled(final boolean cancel) {

paper-api/src/main/java/com/destroystokyo/paper/util/SneakyThrow.java

@@ -3,6 +3,9 @@
 import org.jetbrains.annotations.ApiStatus;
 import org.jspecify.annotations.NullMarked;
 
+/**
+ * @hidden
+ */
 @ApiStatus.Internal
 @NullMarked
 public final class SneakyThrow {

paper-api/src/main/java/com/destroystokyo/paper/util/VersionFetcher.java

@@ -40,6 +40,9 @@ default Component getVersionMessage(String serverVersion) {
         return getVersionMessage();
     }
 
+    /**
+     * @hidden
+     */
     @ApiStatus.Internal
     class DummyVersionFetcher implements VersionFetcher {
 

paper-api/src/main/java/com/destroystokyo/paper/utils/CachedSizeConcurrentLinkedQueue.java

@@ -1,6 +1,5 @@
 package io.papermc.paper.event.block;
 
-import com.google.common.base.Preconditions;
 import org.bukkit.block.Block;
 import org.bukkit.block.data.type.Vault;
 import org.bukkit.entity.Player;
@@ -16,12 +15,14 @@
  */
 @NullMarked
 public class VaultChangeStateEvent extends BlockEvent implements Cancellable {
+
     private static final HandlerList HANDLER_LIST = new HandlerList();
 
     private final @Nullable Player player;
     private final Vault.State currentState;
     private final Vault.State newState;
-    private boolean cancelled = false;
+
+    private boolean cancelled;
 
     @ApiStatus.Internal
     public VaultChangeStateEvent(final Block vaultBlock, final @Nullable Player player, final Vault.State currentState, final Vault.State newState) {
@@ -46,7 +47,7 @@ public VaultChangeStateEvent(final Block vaultBlock, final @Nullable Player play
      * @return The current vault state.
      */
     public Vault.State getCurrentState() {
-        return currentState;
+        return this.currentState;
     }
 
     /**
@@ -55,7 +56,7 @@ public Vault.State getCurrentState() {
      * @return The new vault state.
      */
     public Vault.State getNewState() {
-        return newState;
+        return this.newState;
     }
 
     @Override