Add mob spawner ranges changes and API #9102
Conversation
patches/server/0977-Add-mob-spawner-ranges-changes-and-API.patch
Outdated
Show resolved
Hide resolved
patches/server/0977-Add-mob-spawner-ranges-changes-and-API.patch
Outdated
Show resolved
Hide resolved
patches/server/0977-Add-mob-spawner-ranges-changes-and-API.patch
Outdated
Show resolved
Hide resolved
I agree with these, but how do I make those changes and add them to this PR? I'm new to this whole thing... |
So what you want to do is edit the patches by ammending to the commits you created in |
I've added them - hopefully I did it correctly 😁 |
|
@Machine-Maker do I need to do something now or am I just waiting for this to be approved? |
patches/server/0977-Add-mob-spawner-ranges-changes-and-API.patch
Outdated
Show resolved
Hide resolved
patches/server/0977-Add-mob-spawner-ranges-changes-and-API.patch
Outdated
Show resolved
Hide resolved
|
@Machine-Maker everything changed, anything else needs to be done before this can be merged? |
kennytv
force-pushed
the
add-mob-spawner-ranges-changes-and-api
branch
from
9d81ca5
to
8e97256
Compare
| } | ||
| + | ||
| + // Paper start | ||
| + if (nbt.contains(SPAWN_RANGE_VERTICAL_TAG, 99)) { |
There was a problem hiding this comment.
You can use the Tag.TAG_ANY_NUMERIC constant
| import java.util.Optional; | ||
| import java.util.function.Function; | ||
| import javax.annotation.Nullable; | ||
| + |
There was a problem hiding this comment.
This newline is not needed
| + | ||
| + /** | ||
| + * Set the new vertical spawn range. | ||
| + * <br> |
There was a problem hiding this comment.
This newline is not needed
| + public DefaultMobSpawnerValues defaultMobSpawnerValues; | ||
| + | ||
| + public class DefaultMobSpawnerValues extends ConfigurationPart { | ||
| + public Range range; | ||
| + | ||
| + public class Range extends ConfigurationPart { | ||
| + public int horizontal = 4; | ||
| + public int vertical = 1; | ||
| + } | ||
| + } | ||
| + |
There was a problem hiding this comment.
This should be in the config patch (0005-Paper-config-files.patch)
There was a problem hiding this comment.
I'm not sold on the usefulness or virtue of having the global defaults. They won't apply retroactively to any already-generated spawners because the NBT is already set to 4. I think adding a default for the height is better, but they are already controllable via a plugin.
paper-global.yml)