feat: add caution admonition for plugin loading phases in Velocity #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
zlataovce
reviewed
Aug 17, 2024
zlataovce
approved these changes
Aug 17, 2024
Timongcraft
force-pushed
the
feat/velocity-main-class-warning
branch
from
e18f5d5 to
3e68428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the importance is already considered by adding it to the "Common Pitfalls", I believe it would help if this is marked as a warning to give people a heads-up.
Link to the original page: https://docs.papermc.io/velocity/dev/api-basics#a-word-of-caution
Link to the page: https://timongcraft-feat-velocity-ma.papermc-docs.pages.dev/velocity/dev/api-basics#a-word-of-caution