-
-
Notifications
You must be signed in to change notification settings - Fork 180
Make userdev version be fetched dynamically #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
No idea what the format issue is. If somebody can tell me, please do so |
I'm not particularly fond of creating another component just for userdev, I'd much rather have it be a part of |
@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second |
yes, it should be cached in an expiring value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks fine
This PR fleshes out the Atmospherics design document, laying the groundwork for what Atmospherics is as a department and how players interact with it and its systems. This ddoc will be used as a foundation to write more design documents delving into the various mechanics, future systems, and what things are supposed to be like in Atmospherics. The merging of this document will grant powers to the Atmospherics side of the Engineering/Atmospherics Workgroup.
Instead of hardcoding a version value or focing the user to fetch it itself (previous change to this site), it should just be fetched live.
I have no idea what I am doing, so suggest changes freely