Skip to content

Conversation

Strokkur424
Copy link
Member

Instead of hardcoding a version value or focing the user to fetch it itself (previous change to this site), it should just be fetched live.

I have no idea what I am doing, so suggest changes freely

Copy link

github-actions bot commented Oct 25, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview e8fd871

@Strokkur424
Copy link
Member Author

No idea what the format issue is. If somebody can tell me, please do so

@zlataovce
Copy link
Member

I'm not particularly fond of creating another component just for userdev, I'd much rather have it be a part of VersionFormattedCode (+ the placeholder should be documented in CONTRIBUTING.md)

@Strokkur424
Copy link
Member Author

@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second

@zlataovce
Copy link
Member

@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second

yes, it should be cached in an expiring value

Copy link
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks fine

@zlataovce zlataovce merged commit 085b546 into PaperMC:main Oct 25, 2024
3 checks passed
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
This PR fleshes out the Atmospherics design document, laying the
groundwork for what Atmospherics is as a department and how players
interact with it and its systems. This ddoc will be used as a foundation
to write more design documents delving into the various mechanics,
future systems, and what things are supposed to be like in Atmospherics.

The merging of this document will grant powers to the Atmospherics side
of the Engineering/Atmospherics Workgroup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants