Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New team sprint #458

Merged
merged 27 commits into from
Nov 1, 2016
Merged

New team sprint #458

merged 27 commits into from
Nov 1, 2016

Conversation

ackernaut
Copy link
Member

So far…

  • Updated form component styles
  • Build a static New Team Form
  • Set up state for New Team components in DashSidebar

@mattkrick
Copy link
Member

Just have to write the toast popping logic & then this will be g2g

@ackernaut
Copy link
Member Author

ackernaut commented Oct 31, 2016

Ooh, so I experienced first hand a UI issue.

I entered a team name and tabbed to the textarea for entering multiple email addresses. I typed a first email address and a comma, and then instinctively pressed enter to the next line. The submit button did not work (nothing apparent in console)—but I guess it is treating it as an email formatting error? Is there a way that we can trim return characters in the value?

@mattkrick
Copy link
Member

Nice catch! I'll dig in.

On Oct 31, 2016 11:59 AM, "Terry Acker" notifications@github.com wrote:

Ooh, so I experienced first hand a UI issue.

I entered a team name and tabbed to the textarea for entering multiple
email addresses. I typed a first email address and a comma, and then
instinctively pressed enter to the next line. The submit button would not
working (nothing apparent in console)—but I guess it is treating it as an
email formatting error? Is there a way that we can trim return characters
in the value?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#458 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFQjv_cvtdKmThjs28jB0vxcwhQeCkBUks5q5jpvgaJpZM4Ki2PH
.

@ackernaut
Copy link
Member Author

Gracias @mattkrick !

@mattkrick mattkrick changed the title New team sprint (WIP, DO NOT MERGE) New team sprint Oct 31, 2016
@mattkrick
Copy link
Member

@jordanh ready for 👀

@jordanh
Copy link
Contributor

jordanh commented Nov 1, 2016

Looking now!

Copy link
Contributor

@jordanh jordanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible job! LGTM! 👏

@jordanh jordanh merged commit 83e68ab into master Nov 1, 2016
@jordanh jordanh deleted the new-team-sprint branch November 1, 2016 13:55
@jordanh jordanh removed the building label Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants