Create cache dir if it does not exist before we use tempFile #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be better to just update the previous tests to use a non-existant folder? |
|
LGTM |
|
Looks like there are merge conflicts, so you'll need to rebase and squash before merging. |
wangmengyan95
force-pushed
the
wangmengyan.t8184922_ParseAWSRequest_tempFile_creation
branch
from
21bbd1d to
441aab8
Compare
wangmengyan95
added a commit
that referenced
this pull request
Sep 14, 2015
…AWSRequest_tempFile_creation Create cache dir if it does not exist before we use tempFile
wangmengyan95
deleted the
wangmengyan.t8184922_ParseAWSRequest_tempFile_creation
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in ParseAWSRequest, if users never download/upload any
ParseFile, the cache dir does not exist. In this situation, if users download aParseFile, inParseAWSRequset,new FileOutputStream(tempFile)will throw an exception since parent dir does not exist. By usingParseFileUtils, we create parent dir if it does not exist which fixes this problem.