Skip to content

Create cache dir if it does not exist before we use tempFile #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2015
Merged

Create cache dir if it does not exist before we use tempFile #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
600c8bc
Create cache dir if it does not exist before we create tempFile in Pa…
wangmengyan95 Sep 10, 2015
441aab8
Combine unit test cases
wangmengyan95 Sep 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parse/src/main/java/com/parse/ParseAWSRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public Void call() throws Exception {
InputStream responseStream = null;
try {
responseStream = response.getContent();
FileOutputStream tempFileStream = new FileOutputStream(tempFile);
FileOutputStream tempFileStream = ParseFileUtils.openOutputStream(tempFile);

int nRead;
byte[] data = new byte[32 << 10]; // 32KB
Expand Down
4 changes: 3 additions & 1 deletion Parse/src/test/java/com/parse/ParseFileControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,9 @@ public void testFetchAsyncSuccess() throws Exception {

ParseHttpClient awsClient = mock(ParseHttpClient.class);
when(awsClient.execute(any(ParseHttpRequest.class))).thenReturn(mockResponse);
File root = temporaryFolder.getRoot();
// Make sure cache dir does not exist
File root = new File(temporaryFolder.getRoot(), "cache");
assertFalse(root.exists());
ParseFileController controller = new ParseFileController(null, root).awsClient(awsClient);

ParseFile.State state = new ParseFile.State.Builder()
Expand Down