Fix the bug that wrongly use the GCM when GSF is not fully available. #420
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
| intent.setPackage("com.google.android.gsf"); | ||
| List<ResolveInfo> services = getContext().getPackageManager().queryIntentServices(intent, 0); | ||
| return services != null && services.size() > 0; | ||
| } |
There was a problem hiding this comment.
let's move this method into GcmRegistrar
|
With this change, we shouldn't need |
|
@elvishew updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@elvishew updated the pull request. |
|
I'm not too familiar with this code, @bnham would you have any insight into this? |
| } | ||
|
|
||
| private static boolean isGooglePlayServicesAvailable() { | ||
| return Build.VERSION.SDK_INT >= 8 && getPackageInfo("com.google.android.gsf") != null; |
There was a problem hiding this comment.
Can we simplify this PR by deleting these two lines here and replacing it with the code you wrote for isGcmRegisterServiceAvailable?
|
This looks good, but let's try to minimize the amount of code changed. Can you change your diff so that it just deletes the body of |
ghost
added
the
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@elvishew updated the pull request. |
Pull from official repo
|
@elvishew updated the pull request. |
|
Do we still need this PR? |
|
This PR is very out of date, if OP wants to redo it, feel free. Going to close this one though |
When I am using Parse push notification, I found I always could not receive any push notification if I am using Huawei phones, and finally I found out that the Huawei phone has google service framework, so Parse would choose GCM as push type, but unfortunately, there is no Play Store in the phone, and somehow when Parse try to register the GCM push, it always got GSF_PACKAGE_NOT_AVAILABLE error, so the push notification won't work at all, but if I install Play Store on the phone, the GCM works.
I don't know whether this is a bug of Huawei's OS, or a bug of Parse, I just fix it. If we can not find the GCM register service, we regard the phone as GCM register unavailable.
With this fix, even there is no Play Store installed in Huawei phones, the push can work in a PPNS mode.