Skip to content

Fix the bug that wrongly use the GCM when GSF is not fully available. #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix the bug that wrongly use the GCM when GSF is not fully available. #420

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e698616
Fix the bug that wrongly use the GCM when GSF is not fully available.
Mar 11, 2016
141fba6
Revision for review: remove isGooglePlayServicesAvailable and move
Mar 24, 2016
53bb81f
Revision for review: simplify the change
Aug 3, 2016
c583fca
Merge pull request #1 from ParsePlatform/master
elvishew Aug 4, 2016
ae02d3d
Merge branch 'master' into fix_gcm_bug
Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Parse/src/main/java/com/parse/ManifestInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,11 @@ private static boolean hasAnyGcmSpecificDeclaration() {
}

private static boolean isGooglePlayServicesAvailable() {
return Build.VERSION.SDK_INT >= 8 && getPackageInfo("com.google.android.gsf") != null;
Intent intent = new Intent(GcmRegistrar.REGISTER_ACTION);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this PR by deleting these two lines here and replacing it with the code you wrote for isGcmRegisterServiceAvailable?

intent.setPackage("com.google.android.gsf");
List<ResolveInfo> services = Parse.getApplicationContext().getPackageManager().
queryIntentServices(intent, 0);
return services != null && services.size() > 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this method into GcmRegistrar


private static ManifestCheckResult gcmSupportLevel() {
Expand Down