This repository was archived by the owner on Mar 24, 2021. It is now read-only.
Bleeding #266
Closed
Bleeding #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where, because RequestHandler instances registered themselves with atexit, they would always live until program exit. Having replaced the atexit call with the more usual __del__ finaliser, I found that this __del__ would never run: the queue-handling thread instantiated by RequestHandler holds references to self. Having also replaced that ref by a weakref, we did get the finaliser to run. Finally, to make sure we don't block on Queue.get() forever (in which case the thread still doesn't die), this also adds a timeout to that. Signed-off-by: Yung-Chin Oei <yungchin@yungchin.nl>
Small addition to the parent commit. I figured we might also benefit from a log line in RequestHandler.stop, since it took a while to realise that might hang (see #218). Signed-off-by: Yung-Chin Oei <yungchin@yungchin.nl>
|
oops this was just internal not an actual PR against your master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.