This repository was archived by the owner on Mar 24, 2021. It is now read-only.
producer: avoid messages stuck in queues on stop #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because stop() called _wait_all() after stopping the OwnedBroker threads (and because the OwnedBroker threads stop as soon as they see self.running=False, without trying to check for remaining messages), a situation could occur where the OwnedBroker threads had already exited but a message was still sitting in the queue - resulting in _wait_all() and thus stop() looping forever. We ended up with occasional hangs in test_producer.test_async_produce_context. This is a minimal fix, that just swaps those steps. Signed-off-by: Yung-Chin Oei <yungchin@yungchin.nl>
|
Just ran into this while starting work on producer futures, but now noticed it also happened on travis: https://travis-ci.org/Parsely/pykafka/jobs/81100168 I think this is fairly trivial so will merge right away. |
yungchin
added a commit
that referenced
this pull request
Sep 19, 2015
…ssages producer: avoid messages stuck in queues on stop
|
Looks fine, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because stop() called _wait_all() after stopping the OwnedBroker threads
(and because the OwnedBroker threads stop as soon as they see
self.running=False, without trying to check for remaining messages), a
situation could occur where the OwnedBroker threads had already exited
but a message was still sitting in the queue - resulting in _wait_all()
and thus stop() looping forever. We ended up with occasional hangs in
test_producer.test_async_produce_context.
This is a minimal fix, that just swaps those steps.
Signed-off-by: Yung-Chin Oei yungchin@yungchin.nl